mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-10-24 06:06:09 +00:00
Code Issues 32 Releases Wiki Activity

Fixed #29273 -- Prevented initial selection of empty choice in multiple choice widgets.

Browse Source 
Regression in b52c73008a.
This commit is contained in:
Claude Paroz
2018-03-30 11:55:33 +02:00
committed by Tim Graham
parent d31a248c64
commit f3b69f9757
5 changed files with 19 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/forms_tests/widget_tests/test_selectmultiple.py
View File

@@ -9,7 +9,7 @@ class SelectMultipleTest(WidgetTest):
def test_format_value(self):
widget = self.widget(choices=self.numeric_choices)
self.assertEqual(widget.format_value(None), [''])
self.assertEqual(widget.format_value(None), [])
self.assertEqual(widget.format_value(''), [''])
self.assertEqual(widget.format_value([3, 0, 1]), ['3', '0', '1'])
@@ -35,10 +35,12 @@ class SelectMultipleTest(WidgetTest):
def test_render_none(self):
"""
If the value is None, none of the options are selected.
If the value is None, none of the options are selected, even if the
choices have an empty option.
"""
self.check_html(self.widget(choices=self.beatles), 'beatles', None, html=(
self.check_html(self.widget(choices=(('', 'Unknown'),) + self.beatles), 'beatles', None, html=(
"""<select multiple name="beatles">
<option value="">Unknown</option>
<option value="J">John</option>
<option value="P">Paul</option>
<option value="G">George</option>