From e46dac3201d1d525799a3ea38e1f144b028f1ff2 Mon Sep 17 00:00:00 2001 From: Jaap Roes Date: Tue, 25 Jun 2024 17:09:30 +0200 Subject: [PATCH] Removed superfluous request.user assignment. `auth.login` sets `request.user`, there is no need to assign `request.user` before calling `auth.login`. --- django/contrib/auth/middleware.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/django/contrib/auth/middleware.py b/django/contrib/auth/middleware.py index cb409ee778..d4867031f2 100644 --- a/django/contrib/auth/middleware.py +++ b/django/contrib/auth/middleware.py @@ -142,9 +142,8 @@ class RemoteUserMiddleware(MiddlewareMixin): # to authenticate the user. user = auth.authenticate(request, remote_user=username) if user: - # User is valid. Set request.user and persist user in the session + # User is valid. Set request.user and persist user in the session # by logging the user in. - request.user = user auth.login(request, user) def clean_username(self, username, request):