mirror of
https://github.com/django/django.git
synced 2024-12-25 10:35:48 +00:00
Fixed #12893 -- Added tests to validate that the right queryset is always used in model admins. Thanks to mk and Julien Phalip for their work on the patch.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@15578 bcc190cf-cafb-0310-a4f2-bffc1f526a37
This commit is contained in:
parent
b3c7e399a4
commit
de161fbf21
@ -223,12 +223,50 @@ class ChangeListTests(TransactionTestCase):
|
|||||||
# There's only one ChordsBand instance
|
# There's only one ChordsBand instance
|
||||||
self.assertEqual(cl.result_count, 1)
|
self.assertEqual(cl.result_count, 1)
|
||||||
|
|
||||||
|
def test_pagination(self):
|
||||||
|
"""
|
||||||
|
Regression tests for #12893: Pagination in admins changelist doesn't
|
||||||
|
use queryset set by modeladmin.
|
||||||
|
"""
|
||||||
|
parent = Parent.objects.create(name='anything')
|
||||||
|
for i in range(30):
|
||||||
|
Child.objects.create(name='name %s' % i, parent=parent)
|
||||||
|
Child.objects.create(name='filtered %s' % i, parent=parent)
|
||||||
|
|
||||||
|
request = MockRequest()
|
||||||
|
|
||||||
|
# Test default queryset
|
||||||
|
m = ChildAdmin(Child, admin.site)
|
||||||
|
cl = ChangeList(request, Child, m.list_display, m.list_display_links,
|
||||||
|
m.list_filter, m.date_hierarchy, m.search_fields,
|
||||||
|
m.list_select_related, m.list_per_page, m.list_editable, m)
|
||||||
|
self.assertEqual(cl.query_set.count(), 60)
|
||||||
|
self.assertEqual(cl.paginator.count, 60)
|
||||||
|
self.assertEqual(cl.paginator.page_range, [1, 2, 3, 4, 5, 6])
|
||||||
|
|
||||||
|
# Test custom queryset
|
||||||
|
m = FilteredChildAdmin(Child, admin.site)
|
||||||
|
cl = ChangeList(request, Child, m.list_display, m.list_display_links,
|
||||||
|
m.list_filter, m.date_hierarchy, m.search_fields,
|
||||||
|
m.list_select_related, m.list_per_page, m.list_editable, m)
|
||||||
|
self.assertEqual(cl.query_set.count(), 30)
|
||||||
|
self.assertEqual(cl.paginator.count, 30)
|
||||||
|
self.assertEqual(cl.paginator.page_range, [1, 2, 3])
|
||||||
|
|
||||||
|
|
||||||
class ChildAdmin(admin.ModelAdmin):
|
class ChildAdmin(admin.ModelAdmin):
|
||||||
list_display = ['name', 'parent']
|
list_display = ['name', 'parent']
|
||||||
|
list_per_page = 10
|
||||||
def queryset(self, request):
|
def queryset(self, request):
|
||||||
return super(ChildAdmin, self).queryset(request).select_related("parent__name")
|
return super(ChildAdmin, self).queryset(request).select_related("parent__name")
|
||||||
|
|
||||||
|
class FilteredChildAdmin(admin.ModelAdmin):
|
||||||
|
list_display = ['name', 'parent']
|
||||||
|
list_per_page = 10
|
||||||
|
def queryset(self, request):
|
||||||
|
return super(FilteredChildAdmin, self).queryset(request).filter(
|
||||||
|
name__contains='filtered')
|
||||||
|
|
||||||
class MockRequest(object):
|
class MockRequest(object):
|
||||||
GET = {}
|
GET = {}
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue
Block a user