From dd799591fc9f6ab0d988e0dc82f47276bdab6b2a Mon Sep 17 00:00:00 2001 From: Jacob Kaplan-Moss Date: Fri, 14 Sep 2007 21:53:13 +0000 Subject: [PATCH] Backwards-incompatible change: renamed HttpResponse.headers to HttpResponse._headers to deliberately break anyone accessing headers directly instead of through the case-insensitive proxies on HttpResponse itself. See BackwardsIncompatibleChanges for more details. git-svn-id: http://code.djangoproject.com/svn/django/trunk@6225 bcc190cf-cafb-0310-a4f2-bffc1f526a37 --- django/http/__init__.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/django/http/__init__.py b/django/http/__init__.py index e4aaf5a15f..1de0ffb1df 100644 --- a/django/http/__init__.py +++ b/django/http/__init__.py @@ -246,7 +246,7 @@ class HttpResponse(object): else: self._container = [content] self._is_string = True - self.headers = {'content-type': content_type} + self._headers = {'content-type': content_type} self.cookies = SimpleCookie() if status: self.status_code = status @@ -254,24 +254,24 @@ class HttpResponse(object): def __str__(self): "Full HTTP message, including headers" return '\n'.join(['%s: %s' % (key, value) - for key, value in self.headers.items()]) \ + for key, value in self._headers.items()]) \ + '\n\n' + self.content def __setitem__(self, header, value): - self.headers[header.lower()] = value + self._headers[header.lower()] = value def __delitem__(self, header): try: - del self.headers[header.lower()] + del self._headers[header.lower()] except KeyError: pass def __getitem__(self, header): - return self.headers[header.lower()] + return self._headers[header.lower()] def has_header(self, header): "Case-insensitive check for a header" - return self.headers.has_key(header.lower()) + return self._headers.has_key(header.lower()) __contains__ = has_header