mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-10-24 06:06:09 +00:00
Code Issues 32 Releases Wiki Activity

Fixed ResourceWarning from unclosed SQLite connection on Python 3.13+.

Browse Source 
- backends.sqlite.tests.ThreadSharing.test_database_sharing_in_threads
- backends.tests.ThreadTests.test_default_connection_thread_local:
    on SQLite, close() doesn't explicitly close in-memory connections.
- servers.tests.LiveServerInMemoryDatabaseLockTest
- test_runner.tests.SQLiteInMemoryTestDbs.test_transaction_support

Check out https://github.com/python/cpython/pull/108015.
This commit is contained in:
Mariusz Felisiak
2023-08-23 09:09:23 +02:00
committed by GitHub
parent a9e0f3d301
commit dd45d5223b
4 changed files with 40 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
tests/test_runner/tests.py
View File

@@ -779,16 +779,21 @@ class SQLiteInMemoryTestDbs(TransactionTestCase):
)
with mock.patch("django.test.utils.connections", new=tested_connections):
other = tested_connections["other"]
DiscoverRunner(verbosity=0).setup_databases()
msg = (
"DATABASES setting '%s' option set to sqlite3's ':memory:' value "
"shouldn't interfere with transaction support detection."
% option_key
)
# Transaction support is properly initialized for the 'other' DB.
self.assertTrue(other.features.supports_transactions, msg)
# And all the DBs report that they support transactions.
self.assertTrue(connections_support_transactions(), msg)
try:
new_test_connections = DiscoverRunner(verbosity=0).setup_databases()
msg = (
f"DATABASES setting '{option_key}' option set to sqlite3's "
"':memory:' value shouldn't interfere with transaction support "
"detection."
)
# Transaction support is properly initialized for the
# 'other' DB.
self.assertTrue(other.features.supports_transactions, msg)
# And all the DBs report that they support transactions.
self.assertTrue(connections_support_transactions(), msg)
finally:
for test_connection, _, _ in new_test_connections:
test_connection._close()
class DummyBackendTest(unittest.TestCase):