mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2024-12-22 17:16:24 +00:00
Code Issues 25 Releases Wiki Activity

Expanded QuerySet.explain() error message if a backend supports no formats.

Browse Source
This commit is contained in:
Tim Graham 2022-04-13 20:17:00 -04:00 committed by Mariusz Felisiak
parent a32876606f
commit db83ac48d4
2 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
django/db/backends/base/operations.py
View File

@ -754,6 +754,10 @@ class BaseDatabaseOperations:
msg = "%s is not a recognized format." % normalized_format msg = "%s is not a recognized format." % normalized_format
if supported_formats: if supported_formats:
msg += " Allowed formats: %s" % ", ".join(sorted(supported_formats)) msg += " Allowed formats: %s" % ", ".join(sorted(supported_formats))
else:
msg += (
f" {self.connection.display_name} does not support any formats."
)
raise ValueError(msg) raise ValueError(msg)
if options: if options:
raise ValueError("Unknown options: %s" % ", ".join(sorted(options.keys()))) raise ValueError("Unknown options: %s" % ", ".join(sorted(options.keys())))

2
tests/queries/test_explain.py
View File

@ -74,6 +74,8 @@ class ExplainTests(TestCase):
msg += " Allowed formats: %s" % ", ".join( msg += " Allowed formats: %s" % ", ".join(
sorted(connection.features.supported_explain_formats) sorted(connection.features.supported_explain_formats)
) )
else:
msg += f" {connection.display_name} does not support any formats."
with self.assertRaisesMessage(ValueError, msg): with self.assertRaisesMessage(ValueError, msg):
Tag.objects.explain(format="does not exist") Tag.objects.explain(format="does not exist")