From d6cc37d601166200e72385401f4384f818a18cfd Mon Sep 17 00:00:00 2001 From: Claude Paroz Date: Thu, 21 Nov 2013 08:48:29 +0100 Subject: [PATCH] Updated admindocs to use class-based views Thanks Bouke Haarsma for the review. --- .../admindocs/templates/admin_doc/index.html | 2 +- .../templates/admin_doc/missing_docutils.html | 2 +- django/contrib/admindocs/urls.py | 18 +- django/contrib/admindocs/views.py | 538 +++++++++--------- tests/admin_docs/tests.py | 86 ++- tests/admin_docs/urls.py | 2 + 6 files changed, 361 insertions(+), 287 deletions(-) diff --git a/django/contrib/admindocs/templates/admin_doc/index.html b/django/contrib/admindocs/templates/admin_doc/index.html index 2af43d78c8..aa86a4b549 100644 --- a/django/contrib/admindocs/templates/admin_doc/index.html +++ b/django/contrib/admindocs/templates/admin_doc/index.html @@ -4,7 +4,7 @@ {% block breadcrumbs %} {% endblock %} {% block title %}{% trans 'Documentation' %}{% endblock %} diff --git a/django/contrib/admindocs/templates/admin_doc/missing_docutils.html b/django/contrib/admindocs/templates/admin_doc/missing_docutils.html index bd790f779a..123668f732 100644 --- a/django/contrib/admindocs/templates/admin_doc/missing_docutils.html +++ b/django/contrib/admindocs/templates/admin_doc/missing_docutils.html @@ -4,7 +4,7 @@ {% block breadcrumbs %} {% endblock %} {% block title %}{% trans 'Please install docutils' %}{% endblock %} diff --git a/django/contrib/admindocs/urls.py b/django/contrib/admindocs/urls.py index 4f50049f87..8aa4dcf946 100644 --- a/django/contrib/admindocs/urls.py +++ b/django/contrib/admindocs/urls.py @@ -3,39 +3,39 @@ from django.contrib.admindocs import views urlpatterns = patterns('', url('^$', - views.doc_index, + views.BaseAdminDocsView.as_view(template_name='admin_doc/index.html'), name='django-admindocs-docroot' ), url('^bookmarklets/$', - views.bookmarklets, + views.BookmarkletsView.as_view(), name='django-admindocs-bookmarklets' ), url('^tags/$', - views.template_tag_index, + views.TemplateTagIndexView.as_view(), name='django-admindocs-tags' ), url('^filters/$', - views.template_filter_index, + views.TemplateFilterIndexView.as_view(), name='django-admindocs-filters' ), url('^views/$', - views.view_index, + views.ViewIndexView.as_view(), name='django-admindocs-views-index' ), url('^views/(?P[^/]+)/$', - views.view_detail, + views.ViewDetailView.as_view(), name='django-admindocs-views-detail' ), url('^models/$', - views.model_index, + views.ModelIndexView.as_view(), name='django-admindocs-models-index' ), url('^models/(?P[^\.]+)\.(?P[^/]+)/$', - views.model_detail, + views.ModelDetailView.as_view(), name='django-admindocs-models-detail' ), url('^templates/(?P