mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-08-10 11:59:13 +00:00
Code Issues 32 Releases Wiki Activity

Fixed #34920 -- Made FileExtensionValidator.__eq__() ignore allowed_extensions ordering.

Browse Source
This commit is contained in:
ksg97031 2023-10-24 00:36:18 +09:00 committed by Mariusz Felisiak
parent 171f91d9ef
commit d22ba07630
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
django/core/validators.py
View File

@ -595,7 +595,8 @@ class FileExtensionValidator:
def __eq__(self, other): def __eq__(self, other):
return ( return (
isinstance(other, self.__class__) isinstance(other, self.__class__)
and self.allowed_extensions == other.allowed_extensions and set(self.allowed_extensions or [])
== set(other.allowed_extensions or [])
and self.message == other.message and self.message == other.message
and self.code == other.code and self.code == other.code
) )

4
tests/validators/tests.py
View File

@ -804,6 +804,10 @@ class TestValidatorEquality(TestCase):
FileExtensionValidator(["TXT", "png"]), FileExtensionValidator(["TXT", "png"]),
FileExtensionValidator(["txt", "png"]), FileExtensionValidator(["txt", "png"]),
) )
self.assertEqual(
FileExtensionValidator(["jpg", "png", "txt"]),
FileExtensionValidator(["txt", "jpg", "png"]),
)
self.assertEqual( self.assertEqual(
FileExtensionValidator(["txt"]), FileExtensionValidator(["txt"]),
FileExtensionValidator(["txt"], code="invalid_extension"), FileExtensionValidator(["txt"], code="invalid_extension"),