mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-08-21 01:09:13 +00:00
Code Issues 32 Releases Wiki Activity

Avoided usage of DEBUG setting override in bulk_create tests.

Browse Source 
Asserting an upper bound for the number of executed queries can be achieved by
using CaptureQueriesContext instead of enabling the whole DEBUG machinery.
This commit is contained in:
Simon Charette 2025-07-02 12:18:22 -04:00 committed by Sarah Boyce
parent 5eca562ac3
commit cd0966cd4e
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
tests/bulk_create/tests.py
View File

@ -15,10 +15,10 @@ from django.db.models.functions import Lower, Now
from django.test import ( from django.test import (
TestCase, TestCase,
TransactionTestCase, TransactionTestCase,
override_settings,
skipIfDBFeature, skipIfDBFeature,
skipUnlessDBFeature, skipUnlessDBFeature,
) )
from django.test.utils import CaptureQueriesContext
from django.utils import timezone from django.utils import timezone
from .models import ( from .models import (
@ -217,12 +217,11 @@ class BulkCreateTests(TestCase):
@skipUnlessDBFeature("has_bulk_insert") @skipUnlessDBFeature("has_bulk_insert")
def test_large_batch_efficiency(self): def test_large_batch_efficiency(self):
with override_settings(DEBUG=True): with CaptureQueriesContext(connection) as ctx:
connection.queries_log.clear()
TwoFields.objects.bulk_create( TwoFields.objects.bulk_create(
[TwoFields(f1=i, f2=i + 1) for i in range(0, 1001)] [TwoFields(f1=i, f2=i + 1) for i in range(0, 1001)]
) )
self.assertLess(len(connection.queries), 10) self.assertLess(len(ctx), 10)
def test_large_batch_mixed(self): def test_large_batch_mixed(self):
""" """
@ -248,15 +247,14 @@ class BulkCreateTests(TestCase):
Test inserting a large batch with objects having primary key set Test inserting a large batch with objects having primary key set
mixed together with objects without PK set. mixed together with objects without PK set.
""" """
with override_settings(DEBUG=True): with CaptureQueriesContext(connection) as ctx:
connection.queries_log.clear()
TwoFields.objects.bulk_create( TwoFields.objects.bulk_create(
[ [
TwoFields(id=i if i % 2 == 0 else None, f1=i, f2=i + 1) TwoFields(id=i if i % 2 == 0 else None, f1=i, f2=i + 1)
for i in range(100000, 101000) for i in range(100000, 101000)
] ]
) )
self.assertLess(len(connection.queries), 10) self.assertLess(len(ctx), 10)
def test_explicit_batch_size(self): def test_explicit_batch_size(self):
objs = [TwoFields(f1=i, f2=i) for i in range(0, 4)] objs = [TwoFields(f1=i, f2=i) for i in range(0, 4)]