From cc8c02fa0fa2119704d1c39ca8509850aef84acc Mon Sep 17 00:00:00 2001 From: Simon Charette Date: Wed, 11 Nov 2015 00:49:35 -0500 Subject: [PATCH] Refs #25693 -- Added a regression test for `to_attr` validation on forward m2m. --- tests/prefetch_related/tests.py | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/tests/prefetch_related/tests.py b/tests/prefetch_related/tests.py index cd763bb950..56bd64b5b9 100644 --- a/tests/prefetch_related/tests.py +++ b/tests/prefetch_related/tests.py @@ -223,7 +223,18 @@ class PrefetchRelatedTests(TestCase): self.assertIn('prefetch_related', str(cm.exception)) self.assertIn("name", str(cm.exception)) - def test_m2m_shadow(self): + def test_forward_m2m_to_attr_conflict(self): + msg = 'to_attr=authors conflicts with a field on the Book model.' + authors = Author.objects.all() + with self.assertRaisesMessage(ValueError, msg): + list(Book.objects.prefetch_related( + Prefetch('authors', queryset=authors, to_attr='authors'), + )) + # Without the ValueError, an author was deleted due to the implicit + # save of the relation assignment. + self.assertEqual(self.book1.authors.count(), 3) + + def test_reverse_m2m_to_attr_conflict(self): msg = 'to_attr=books conflicts with a field on the Author model.' poems = Book.objects.filter(title='Poems') with self.assertRaisesMessage(ValueError, msg):