mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-06-05 11:39:13 +00:00
Code Issues 32 Releases Wiki Activity

Fixed #19637 -- Ensured AdminEmailHandler fails silently

Browse Source 
Thanks lsaffre for the report. Refs #19325.
This commit is contained in:
Claude Paroz 2013-01-21 20:27:38 +01:00
parent 7aa538357c
commit c6e0dedbdb
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
django/utils/log.py
View File

@ -117,7 +117,7 @@ class AdminEmailHandler(logging.Handler):
connection=self.connection()) connection=self.connection())
def connection(self): def connection(self):
return get_connection(backend=self.email_backend) return get_connection(backend=self.email_backend, fail_silently=True)
def format_subject(self, subject): def format_subject(self, subject):
""" """

4
tests/regressiontests/logging_tests/tests.py
View File

@ -154,6 +154,10 @@ class AdminEmailHandlerTest(TestCase):
][0] ][0]
return admin_email_handler return admin_email_handler
def test_fail_silently(self):
admin_email_handler = self.get_admin_email_handler(self.logger)
self.assertTrue(admin_email_handler.connection().fail_silently)
@override_settings( @override_settings(
ADMINS=(('whatever admin', 'admin@example.com'),), ADMINS=(('whatever admin', 'admin@example.com'),),
EMAIL_SUBJECT_PREFIX='-SuperAwesomeSubject-' EMAIL_SUBJECT_PREFIX='-SuperAwesomeSubject-'