1
0
mirror of https://github.com/django/django.git synced 2025-10-26 15:16:09 +00:00

Fixed #23107 -- Made runserver output respect --no-color.

This commit reverts 67d7da5fb9.

The previous fix changed the environment globally, which meant
that any call to `call_command(no_color=True)` prevented further
`call_command` with color.

This fix still relies on the environment because it's currently the only
way to reach WSGIRequestHandler, but it's now limited to the `runserver`
command. This seems an acceptable compromise considering `runserver` runs
indefinitely.

Thanks Tim Graham for the review.
This commit is contained in:
Loic Bistuer
2014-10-20 18:01:03 +07:00
parent 9f1202c166
commit c34e13e17c
3 changed files with 8 additions and 2 deletions

View File

@@ -386,7 +386,6 @@ class BaseCommand(object):
if options.get('no_color'):
self.style = no_style()
self.stderr = OutputWrapper(options.get('stderr', sys.stderr))
os.environ[str("DJANGO_COLORS")] = str("nocolor")
else:
self.stderr = OutputWrapper(options.get('stderr', sys.stderr), self.style.ERROR)