1
0
mirror of https://github.com/django/django.git synced 2025-07-05 10:19:20 +00:00

[1.1.X] Fixed #10130: you may now delete attributes on settings. Thanks, jcassee.

Backport of r11824.

git-svn-id: http://code.djangoproject.com/svn/django/branches/releases/1.1.X@11825 bcc190cf-cafb-0310-a4f2-bffc1f526a37
This commit is contained in:
Jacob Kaplan-Moss 2009-12-12 17:53:32 +00:00
parent 5e6c3d24b3
commit c1a8bd6779
4 changed files with 24 additions and 0 deletions

View File

@ -280,6 +280,13 @@ class LazyObject(object):
self._setup()
setattr(self._wrapped, name, value)
def __delattr__(self, name):
if name == "_wrapped":
raise TypeError("can't delete _wrapped.")
if self._wrapped is None:
self._setup()
delattr(self._wrapped, name)
def _setup(self):
"""
Must be implemented by subclasses to initialise the wrapped object.

View File

View File

@ -0,0 +1,17 @@
import unittest
from django.conf import settings
class SettingsTests(unittest.TestCase):
#
# Regression tests for #10130: deleting settings.
#
def test_settings_delete(self):
settings.TEST = 'test'
self.assertEqual('test', settings.TEST)
del settings.TEST
self.assertRaises(AttributeError, getattr, settings, 'TEST')
def test_settings_delete_wrapped(self):
self.assertRaises(TypeError, delattr, settings, '_wrapped')