mirror of
https://github.com/django/django.git
synced 2025-10-31 09:41:08 +00:00
Fixed #17905 -- Restricted access to model pages in admindocs.
Only users with view or change model permissions can access. Thank you to Sarah Boyce for the review.
This commit is contained in:
committed by
Sarah Boyce
parent
ef8ae06c2a
commit
c12bc980e5
@@ -13,7 +13,12 @@ from django.contrib.admindocs.utils import (
|
||||
replace_named_groups,
|
||||
replace_unnamed_groups,
|
||||
)
|
||||
from django.core.exceptions import ImproperlyConfigured, ViewDoesNotExist
|
||||
from django.contrib.auth import get_permission_codename
|
||||
from django.core.exceptions import (
|
||||
ImproperlyConfigured,
|
||||
PermissionDenied,
|
||||
ViewDoesNotExist,
|
||||
)
|
||||
from django.db import models
|
||||
from django.http import Http404
|
||||
from django.template.engine import Engine
|
||||
@@ -202,11 +207,24 @@ class ViewDetailView(BaseAdminDocsView):
|
||||
)
|
||||
|
||||
|
||||
def user_has_model_view_permission(user, opts):
|
||||
"""Based off ModelAdmin.has_view_permission."""
|
||||
codename_view = get_permission_codename("view", opts)
|
||||
codename_change = get_permission_codename("change", opts)
|
||||
return user.has_perm("%s.%s" % (opts.app_label, codename_view)) or user.has_perm(
|
||||
"%s.%s" % (opts.app_label, codename_change)
|
||||
)
|
||||
|
||||
|
||||
class ModelIndexView(BaseAdminDocsView):
|
||||
template_name = "admin_doc/model_index.html"
|
||||
|
||||
def get_context_data(self, **kwargs):
|
||||
m_list = [m._meta for m in apps.get_models()]
|
||||
m_list = [
|
||||
m._meta
|
||||
for m in apps.get_models()
|
||||
if user_has_model_view_permission(self.request.user, m._meta)
|
||||
]
|
||||
return super().get_context_data(**{**kwargs, "models": m_list})
|
||||
|
||||
|
||||
@@ -228,6 +246,8 @@ class ModelDetailView(BaseAdminDocsView):
|
||||
)
|
||||
|
||||
opts = model._meta
|
||||
if not user_has_model_view_permission(self.request.user, opts):
|
||||
raise PermissionDenied
|
||||
|
||||
title, body, metadata = utils.parse_docstring(model.__doc__)
|
||||
title = title and utils.parse_rst(title, "model", _("model:") + model_name)
|
||||
|
||||
Reference in New Issue
Block a user