mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-10-24 06:06:09 +00:00
Code Issues 32 Releases Wiki Activity

Refs #31359 -- Made get_random_string()'s length argument required.

Browse Source 
Per deprecation timeline.
This commit is contained in:
Mariusz Felisiak
2021-01-13 22:33:42 +01:00
parent d992f4e3c2
commit be6e468130
3 changed files with 6 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
tests/utils_tests/test_crypto.py
View File

@@ -1,12 +1,10 @@
import hashlib
import unittest
from django.test import SimpleTestCase, ignore_warnings
from django.test import SimpleTestCase
from django.utils.crypto import (
InvalidAlgorithm, constant_time_compare, get_random_string, pbkdf2,
salted_hmac,
InvalidAlgorithm, constant_time_compare, pbkdf2, salted_hmac,
)
from django.utils.deprecation import RemovedInDjango40Warning
class TestUtilsCryptoMisc(SimpleTestCase):
@@ -185,14 +183,3 @@ class TestUtilsCryptoPBKDF2(unittest.TestCase):
def test_default_hmac_alg(self):
kwargs = {'password': b'password', 'salt': b'salt', 'iterations': 1, 'dklen': 20}
self.assertEqual(pbkdf2(**kwargs), hashlib.pbkdf2_hmac(hash_name=hashlib.sha256().name, **kwargs))
class DeprecationTests(SimpleTestCase):
@ignore_warnings(category=RemovedInDjango40Warning)
def test_get_random_string(self):
self.assertEqual(len(get_random_string()), 12)
def test_get_random_string_warning(self):
msg = 'Not providing a length argument is deprecated.'
with self.assertRaisesMessage(RemovedInDjango40Warning, msg):
get_random_string()