mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-06-05 03:29:12 +00:00
Code Issues 32 Releases Wiki Activity

Fixed #5560 -- Improved the way we create __str__ and __unicode__ methods in

Browse Source 
lazy() objects. This fixes things for Jython and makes the code more readable,
even for CPython. Thanks, Leo Soto.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@6587 bcc190cf-cafb-0310-a4f2-bffc1f526a37
This commit is contained in:
Malcolm Tredinnick 2007-10-21 18:35:31 +00:00
parent 2adcb3f250
commit bab4fdc9fd
1 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
django/utils/functional.py
View File

@ -53,7 +53,11 @@ def lazy(func, *resultclasses):
self._delegate_unicode = unicode in resultclasses self._delegate_unicode = unicode in resultclasses
assert not (self._delegate_str and self._delegate_unicode), "Cannot call lazy() with both str and unicode return types." assert not (self._delegate_str and self._delegate_unicode), "Cannot call lazy() with both str and unicode return types."
if self._delegate_unicode: if self._delegate_unicode:
self.__unicode__ = self.__unicode_cast # Each call to lazy() makes a new __proxy__ object, so this
# doesn't interfere with any other lazy() results.
__proxy__.__unicode__ = __proxy__.__unicode_cast
elif self._delegate_str:
__proxy__.__str__ = __proxy__.__str_cast
def __promise__(self, klass, funcname, func): def __promise__(self, klass, funcname, func):
# Builds a wrapper around some magic method and registers that magic # Builds a wrapper around some magic method and registers that magic
@ -72,14 +76,8 @@ def lazy(func, *resultclasses):
def __unicode_cast(self): def __unicode_cast(self):
return self.__func(*self.__args, **self.__kw) return self.__func(*self.__args, **self.__kw)
def __str__(self): def __str_cast(self):
# As __str__ is always a method on the type (class), it is looked return str(self.__func(*self.__args, **self.__kw))
# up (and found) there first. So we can't just assign to it on a
# per-instance basis in __init__.
if self._delegate_str:
return str(self.__func(*self.__args, **self.__kw))
else:
return Promise.__str__(self)
def __cmp__(self, rhs): def __cmp__(self, rhs):
if self._delegate_str: if self._delegate_str: