mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-10-31 09:41:08 +00:00
Code Issues 32 Releases Wiki Activity

Fixed #30757 -- Added a system check to ensure max_length fits the longest choice.

Browse Source
This commit is contained in:
Nick Pope
2019-09-04 09:21:08 +01:00
committed by Mariusz Felisiak
parent fee75d2aed
commit b6251956b6
3 changed files with 45 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
django/db/models/fields/__init__.py
View File

@@ -257,6 +257,7 @@ class Field(RegisterLookupMixin):
)
]
choice_max_length = 0
# Expect [group_name, [value, display]]
for choices_group in self.choices:
try:
@@ -270,16 +271,32 @@ class Field(RegisterLookupMixin):
for value, human_name in group_choices
):
break
if self.max_length is not None and group_choices:
choice_max_length = max(
choice_max_length,
*(len(value) for value, _ in group_choices if isinstance(value, str)),
)
except (TypeError, ValueError):
# No groups, choices in the form [value, display]
value, human_name = group_name, group_choices
if not is_value(value) or not is_value(human_name):
break
if self.max_length is not None and isinstance(value, str):
choice_max_length = max(choice_max_length, len(value))
# Special case: choices=['ab']
if isinstance(choices_group, str):
break
else:
if self.max_length is not None and choice_max_length > self.max_length:
return [
checks.Error(
"'max_length' is too small to fit the longest value "
"in 'choices' (%d characters)." % choice_max_length,
obj=self,
id='fields.E009',
),
]
return []
return [