mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2024-12-23 09:36:06 +00:00
Code Issues 25 Releases Wiki Activity

Fixed #32298 -- Fixed URLValidator hostname length validation.

Browse Source 
URLValidator now validates the maximum length of a hostname without
the userinfo and port.
This commit is contained in:
Akshat1Nar 2020-12-26 20:52:44 +05:30 committed by Mariusz Felisiak
parent 966ed414b2
commit b41d38ae26
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
django/core/validators.py
View File

@ -138,7 +138,7 @@ class URLValidator(RegexValidator):
# section 3.1. It's defined to be 255 bytes or less, but this includes # section 3.1. It's defined to be 255 bytes or less, but this includes
# one byte for the length of the name and one byte for the trailing dot # one byte for the length of the name and one byte for the trailing dot
# that's used to indicate absolute names in DNS. # that's used to indicate absolute names in DNS.
if len(urlsplit(value).netloc) > 253: if len(urlsplit(value).hostname) > 253:
raise ValidationError(self.message, code=self.code, params={'value': value}) raise ValidationError(self.message, code=self.code, params={'value': value})

4
tests/validators/valid_urls.txt
View File

@ -35,6 +35,10 @@ http://userid:password@example.com
http://userid:password@example.com/ http://userid:password@example.com/
http://userid:password@example.com:8080 http://userid:password@example.com:8080
http://userid:password@example.com:8080/ http://userid:password@example.com:8080/
https://userid:paaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaassword@example.com
https://userid:paaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaassword@example.com:8080
https://useridddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddd:password@example.com
https://useriddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddd:password@example.com:8080
http://142.42.1.1/ http://142.42.1.1/
http://142.42.1.1:8080/ http://142.42.1.1:8080/
http://➡.ws/䨹 http://➡.ws/䨹