mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-10-24 06:06:09 +00:00
Code Issues 32 Releases Wiki Activity

Fixed #36034 -- Added system check for ForeignKey/ForeignObject/ManyToManyField to CompositePrimaryKeys.

Browse Source
This commit is contained in:
Mariusz Felisiak
2025-01-01 10:23:56 +01:00
committed by Sarah Boyce
parent 2a61b5f97c
commit b322319f9d
3 changed files with 178 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

129
tests/invalid_models_tests/test_relative_fields.py
View File

@@ -440,6 +440,84 @@ class RelativeFieldTests(SimpleTestCase):
],
)
def test_foreignkey_to_model_with_composite_primary_key(self):
class Parent(models.Model):
pk = models.CompositePrimaryKey("version", "name")
version = models.IntegerField()
name = models.CharField(max_length=20)
class Child(models.Model):
rel_class_parent = models.ForeignKey(
Parent, on_delete=models.CASCADE, related_name="child_class_set"
)
rel_string_parent = models.ForeignKey(
"Parent", on_delete=models.CASCADE, related_name="child_string_set"
)
field = Child._meta.get_field("rel_string_parent")
self.assertEqual(
field.check(),
[
Error(
"Field defines a relation to the CompositePrimaryKey of model "
"'Parent' which is not supported.",
obj=field,
id="fields.E347",
),
],
)
field = Child._meta.get_field("rel_class_parent")
self.assertEqual(
field.check(),
[
Error(
"Field defines a relation to the CompositePrimaryKey of model "
"'Parent' which is not supported.",
obj=field,
id="fields.E347",
),
],
)
def test_many_to_many_to_model_with_composite_primary_key(self):
class Parent(models.Model):
pk = models.CompositePrimaryKey("version", "name")
version = models.IntegerField()
name = models.CharField(max_length=20)
class Child(models.Model):
rel_class_parent = models.ManyToManyField(
Parent, related_name="child_class_set"
)
rel_string_parent = models.ManyToManyField(
"Parent", related_name="child_string_set"
)
field = Child._meta.get_field("rel_string_parent")
self.assertEqual(
field.check(from_model=Child),
[
Error(
"Field defines a relation to the CompositePrimaryKey of model "
"'Parent' which is not supported.",
obj=field,
id="fields.E347",
),
],
)
field = Child._meta.get_field("rel_class_parent")
self.assertEqual(
field.check(from_model=Child),
[
Error(
"Field defines a relation to the CompositePrimaryKey of model "
"'Parent' which is not supported.",
obj=field,
id="fields.E347",
),
],
)
def test_foreign_key_to_non_unique_field(self):
class Target(models.Model):
bad = models.IntegerField() # No unique=True
@@ -939,6 +1017,57 @@ class RelativeFieldTests(SimpleTestCase):
],
)
def test_to_fields_with_composite_primary_key(self):
class Parent(models.Model):
pk = models.CompositePrimaryKey("version", "name")
version = models.IntegerField()
name = models.CharField(max_length=20)
class Child(models.Model):
a = models.IntegerField()
b = models.IntegerField()
parent = models.ForeignObject(
Parent,
on_delete=models.SET_NULL,
from_fields=("a", "b"),
to_fields=("pk", "version"),
)
field = Child._meta.get_field("parent")
self.assertEqual(
field.check(),
[
Error(
"Field defines a relation to the CompositePrimaryKey of model "
"'Parent' which is not supported.",
obj=field,
id="fields.E347",
),
],
)
def test_to_field_to_composite_primery_key(self):
class Parent(models.Model):
pk = models.CompositePrimaryKey("version", "name")
version = models.IntegerField()
name = models.CharField(max_length=20)
class Child(models.Model):
parent = models.ForeignKey(Parent, on_delete=models.CASCADE, to_field="pk")
field = Child._meta.get_field("parent")
self.assertEqual(
field.check(),
[
Error(
"Field defines a relation to the CompositePrimaryKey of model "
"'Parent' which is not supported.",
obj=field,
id="fields.E347",
),
],
)
def test_invalid_related_query_name(self):
class Target(models.Model):
pass