mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-03-14 03:10:45 +00:00
Code Issues32 Releases Wiki Activity

Optimized Case.as_sql() default compilation.

Browse Source 
Moving compiler.compile(self.default) to the else clause avoids
the call when it's unneeded in the FullResultSet case.
This commit is contained in:
Tim Graham 2024-06-21 17:51:56 -04:00 committed by Sarah Boyce
parent 7264d7f750
commit b2fec1f08d
1 changed files with 2 additions and 1 deletions

3
django/db/models/expressions.py

@ -1613,7 +1613,6 @@ class Case(SQLiteNumericMixin, Expression):
template_params = {**self.extra, **extra_context} template_params = {**self.extra, **extra_context}
case_parts = [] case_parts = []
sql_params = [] sql_params = []
default_sql, default_params = compiler.compile(self.default)
for case in self.cases: for case in self.cases:
try: try:
case_sql, case_params = compiler.compile(case) case_sql, case_params = compiler.compile(case)
@ -1624,6 +1623,8 @@ class Case(SQLiteNumericMixin, Expression):
break break
case_parts.append(case_sql) case_parts.append(case_sql)
sql_params.extend(case_params) sql_params.extend(case_params)
else:
default_sql, default_params = compiler.compile(self.default)
if not case_parts: if not case_parts:
return default_sql, default_params return default_sql, default_params
case_joiner = case_joiner or self.case_joiner case_joiner = case_joiner or self.case_joiner