mirror of
https://github.com/django/django.git
synced 2024-12-22 17:16:24 +00:00
Fixed #32360 -- Added system check for FILE_UPLOAD_TEMP_DIR setting.
This commit is contained in:
parent
725c549ae7
commit
b1821fbad5
1
AUTHORS
1
AUTHORS
@ -897,6 +897,7 @@ answer newbie questions, and generally made Django that much better:
|
|||||||
Tim Givois <tim.givois.mendez@gmail.com>
|
Tim Givois <tim.givois.mendez@gmail.com>
|
||||||
Tim Graham <timograham@gmail.com>
|
Tim Graham <timograham@gmail.com>
|
||||||
Tim Heap <tim@timheap.me>
|
Tim Heap <tim@timheap.me>
|
||||||
|
Tim McCurrach <tim.mccurrach@gmail.com>
|
||||||
Tim Saylor <tim.saylor@gmail.com>
|
Tim Saylor <tim.saylor@gmail.com>
|
||||||
Tobias Kunze <rixx@cutebit.de>
|
Tobias Kunze <rixx@cutebit.de>
|
||||||
Tobias McNulty <https://www.caktusgroup.com/blog/>
|
Tobias McNulty <https://www.caktusgroup.com/blog/>
|
||||||
|
@ -8,6 +8,7 @@ from .registry import Tags, register, run_checks, tag_exists
|
|||||||
import django.core.checks.async_checks # NOQA isort:skip
|
import django.core.checks.async_checks # NOQA isort:skip
|
||||||
import django.core.checks.caches # NOQA isort:skip
|
import django.core.checks.caches # NOQA isort:skip
|
||||||
import django.core.checks.database # NOQA isort:skip
|
import django.core.checks.database # NOQA isort:skip
|
||||||
|
import django.core.checks.files # NOQA isort:skip
|
||||||
import django.core.checks.model_checks # NOQA isort:skip
|
import django.core.checks.model_checks # NOQA isort:skip
|
||||||
import django.core.checks.security.base # NOQA isort:skip
|
import django.core.checks.security.base # NOQA isort:skip
|
||||||
import django.core.checks.security.csrf # NOQA isort:skip
|
import django.core.checks.security.csrf # NOQA isort:skip
|
||||||
|
19
django/core/checks/files.py
Normal file
19
django/core/checks/files.py
Normal file
@ -0,0 +1,19 @@
|
|||||||
|
from pathlib import Path
|
||||||
|
|
||||||
|
from django.conf import settings
|
||||||
|
|
||||||
|
from . import Error, Tags, register
|
||||||
|
|
||||||
|
|
||||||
|
@register(Tags.files)
|
||||||
|
def check_setting_file_upload_temp_dir(app_configs, **kwargs):
|
||||||
|
setting = getattr(settings, 'FILE_UPLOAD_TEMP_DIR', None)
|
||||||
|
if setting and not Path(setting).is_dir():
|
||||||
|
return [
|
||||||
|
Error(
|
||||||
|
f"The FILE_UPLOAD_TEMP_DIR setting refers to the nonexistent "
|
||||||
|
f"directory '{setting}'.",
|
||||||
|
id="files.E001",
|
||||||
|
),
|
||||||
|
]
|
||||||
|
return []
|
@ -13,6 +13,7 @@ class Tags:
|
|||||||
caches = 'caches'
|
caches = 'caches'
|
||||||
compatibility = 'compatibility'
|
compatibility = 'compatibility'
|
||||||
database = 'database'
|
database = 'database'
|
||||||
|
files = 'files'
|
||||||
models = 'models'
|
models = 'models'
|
||||||
security = 'security'
|
security = 'security'
|
||||||
signals = 'signals'
|
signals = 'signals'
|
||||||
|
@ -82,6 +82,7 @@ Django's system checks are organized using the following tags:
|
|||||||
regular checks do. They are only run by the :djadmin:`migrate` command or if
|
regular checks do. They are only run by the :djadmin:`migrate` command or if
|
||||||
you specify configured database aliases using the ``--database`` option when
|
you specify configured database aliases using the ``--database`` option when
|
||||||
calling the :djadmin:`check` command.
|
calling the :djadmin:`check` command.
|
||||||
|
* ``files``: Checks files related configuration.
|
||||||
* ``models``: Checks of model, field, and manager definitions.
|
* ``models``: Checks of model, field, and manager definitions.
|
||||||
* ``security``: Checks security related configuration.
|
* ``security``: Checks security related configuration.
|
||||||
* ``signals``: Checks on signal declarations and handler registrations.
|
* ``signals``: Checks on signal declarations and handler registrations.
|
||||||
@ -97,6 +98,10 @@ Some checks may be registered with multiple tags.
|
|||||||
|
|
||||||
The ``sites`` tag was added.
|
The ``sites`` tag was added.
|
||||||
|
|
||||||
|
.. versionchanged:: 4.0
|
||||||
|
|
||||||
|
The ``files`` tag was added.
|
||||||
|
|
||||||
Core system checks
|
Core system checks
|
||||||
==================
|
==================
|
||||||
|
|
||||||
@ -150,6 +155,16 @@ If you're using MySQL or MariaDB, the following checks will be performed:
|
|||||||
* **mysql.W003**: MySQL/MariaDB may not allow unique ``CharField``\s to have a
|
* **mysql.W003**: MySQL/MariaDB may not allow unique ``CharField``\s to have a
|
||||||
``max_length`` > 255.
|
``max_length`` > 255.
|
||||||
|
|
||||||
|
Managing files
|
||||||
|
--------------
|
||||||
|
|
||||||
|
.. versionadded:: 4.0
|
||||||
|
|
||||||
|
The following checks verify your setup for :doc:`/topics/files`:
|
||||||
|
|
||||||
|
* **files.E001**: The :setting:`FILE_UPLOAD_TEMP_DIR` setting refers to the
|
||||||
|
nonexistent directory ``<path>``.
|
||||||
|
|
||||||
Model fields
|
Model fields
|
||||||
------------
|
------------
|
||||||
|
|
||||||
|
32
tests/check_framework/test_files.py
Normal file
32
tests/check_framework/test_files.py
Normal file
@ -0,0 +1,32 @@
|
|||||||
|
from pathlib import Path
|
||||||
|
|
||||||
|
from django.core.checks import Error
|
||||||
|
from django.core.checks.files import check_setting_file_upload_temp_dir
|
||||||
|
from django.test import SimpleTestCase
|
||||||
|
|
||||||
|
|
||||||
|
class FilesCheckTests(SimpleTestCase):
|
||||||
|
def test_file_upload_temp_dir(self):
|
||||||
|
tests = [
|
||||||
|
None,
|
||||||
|
'',
|
||||||
|
Path.cwd(),
|
||||||
|
str(Path.cwd()),
|
||||||
|
]
|
||||||
|
for setting in tests:
|
||||||
|
with self.subTest(setting), self.settings(FILE_UPLOAD_TEMP_DIR=setting):
|
||||||
|
self.assertEqual(check_setting_file_upload_temp_dir(None), [])
|
||||||
|
|
||||||
|
def test_file_upload_temp_dir_nonexistent(self):
|
||||||
|
for setting in ['nonexistent', Path('nonexistent')]:
|
||||||
|
with self.subTest(setting), self.settings(FILE_UPLOAD_TEMP_DIR=setting):
|
||||||
|
self.assertEqual(
|
||||||
|
check_setting_file_upload_temp_dir(None),
|
||||||
|
[
|
||||||
|
Error(
|
||||||
|
"The FILE_UPLOAD_TEMP_DIR setting refers to the "
|
||||||
|
"nonexistent directory 'nonexistent'.",
|
||||||
|
id='files.E001',
|
||||||
|
),
|
||||||
|
],
|
||||||
|
)
|
Loading…
Reference in New Issue
Block a user