From b151bccdcc654856b849ab19b6deb68c22794e23 Mon Sep 17 00:00:00 2001 From: Russell Keith-Magee Date: Mon, 21 Feb 2011 13:45:57 +0000 Subject: [PATCH] Fixed #15359 -- Ensure that the -h option is always honored by django-admin.py. Thanks to teubank for the report. git-svn-id: http://code.djangoproject.com/svn/django/trunk@15605 bcc190cf-cafb-0310-a4f2-bffc1f526a37 --- django/core/management/__init__.py | 2 +- tests/regressiontests/admin_scripts/tests.py | 10 ++++++++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/django/core/management/__init__.py b/django/core/management/__init__.py index 85bf324fdc..bafab17112 100644 --- a/django/core/management/__init__.py +++ b/django/core/management/__init__.py @@ -372,7 +372,7 @@ class ManagementUtility(object): elif self.argv[1:] == ['--version']: # LaxOptionParser already takes care of printing the version. pass - elif self.argv[1:] == ['--help']: + elif self.argv[1:] in (['--help'], ['-h']): parser.print_lax_help() sys.stderr.write(self.main_help_text() + '\n') else: diff --git a/tests/regressiontests/admin_scripts/tests.py b/tests/regressiontests/admin_scripts/tests.py index 5c2f5d7fb6..76cecc0842 100644 --- a/tests/regressiontests/admin_scripts/tests.py +++ b/tests/regressiontests/admin_scripts/tests.py @@ -1115,6 +1115,16 @@ class CommandTypes(AdminScriptTestCase): self.assertOutput(out, "Usage: manage.py subcommand [options] [args]") self.assertOutput(err, "Type 'manage.py help ' for help on a specific subcommand.") + def test_short_help(self): + "-h is handled as a short form of --help" + args = ['-h'] + out, err = self.run_manage(args) + if sys.version_info < (2, 5): + self.assertOutput(out, "usage: manage.py subcommand [options] [args]") + else: + self.assertOutput(out, "Usage: manage.py subcommand [options] [args]") + self.assertOutput(err, "Type 'manage.py help ' for help on a specific subcommand.") + def test_specific_help(self): "--help can be used on a specific command" args = ['sqlall','--help']