From afe6634146d0fe70498976c49d2eb4d745aa9064 Mon Sep 17 00:00:00 2001 From: okaybro <66475772+Chaitanya-Keyal@users.noreply.github.com> Date: Mon, 1 Sep 2025 23:09:41 +0000 Subject: [PATCH] Fixed #36587 -- Clarified usage of `list.insert()` for upload handlers. Thanks Baptiste Mispelon for the report Co-authored-by: Natalia <124304+nessita@users.noreply.github.com> --- AUTHORS | 1 + docs/topics/http/file-uploads.txt | 7 ++++--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/AUTHORS b/AUTHORS index 4b1cc7d357..4204dc9f2b 100644 --- a/AUTHORS +++ b/AUTHORS @@ -209,6 +209,7 @@ answer newbie questions, and generally made Django that much better: Carlton Gibson cedric@terramater.net Chad Whitman + Chaitanya Keyal ChaosKCW Charlie Leifer charly.wilhelm@gmail.com diff --git a/docs/topics/http/file-uploads.txt b/docs/topics/http/file-uploads.txt index f9327808b5..60b3e1a86e 100644 --- a/docs/topics/http/file-uploads.txt +++ b/docs/topics/http/file-uploads.txt @@ -289,9 +289,10 @@ this handler to your upload handlers like this:: request.upload_handlers.insert(0, ProgressBarUploadHandler(request)) -You'd probably want to use ``list.insert()`` in this case (instead of -``append()``) because a progress bar handler would need to run *before* any -other handlers. Remember, the upload handlers are processed in order. +Using ``list.insert()``, as shown above, ensures that the progress bar handler +is placed at the beginning of the list. Since upload handlers are executed in +order, this placement guarantees that the progress bar handler runs before the +default handlers, allowing it to track progress across the entire upload. If you want to replace the upload handlers completely, you can assign a new list::