mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-03-31 19:46:42 +00:00
Code Issues 32 Releases Wiki Activity

Fixed #30189 -- Removed transaction from sqlmigrate output if database doesn't use one.

Browse Source
This commit is contained in:
Parth Patil 2019-03-08 04:58:22 +05:30 committed by Tim Graham
parent d527639804
commit acc041984f
2 changed files with 32 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
django/core/management/commands/sqlmigrate.py
View File

@ -55,8 +55,9 @@ class Command(BaseCommand):
migration_name, app_label)) migration_name, app_label))
targets = [(app_label, migration.name)] targets = [(app_label, migration.name)]
# Show begin/end around output only for atomic migrations # Show begin/end around output for atomic migrations, if the database
self.output_transaction = migration.atomic # supports transactional DDL.
self.output_transaction = migration.atomic and connection.features.can_rollback_ddl
# Make a plan that represents just the requested migrations and show SQL # Make a plan that represents just the requested migrations and show SQL
# for it # for it

39
tests/migrations/test_commands.py
View File

@ -536,7 +536,13 @@ class MigrateTests(MigrationTestBase):
index_op_desc_unique_together = output.find('-- alter unique_together') index_op_desc_unique_together = output.find('-- alter unique_together')
index_tx_end = output.find(connection.ops.end_transaction_sql().lower()) index_tx_end = output.find(connection.ops.end_transaction_sql().lower())
self.assertGreater(index_tx_start, -1, "Transaction start not found") if connection.features.can_rollback_ddl:
self.assertGreater(index_tx_start, -1, "Transaction start not found")
self.assertGreater(
index_tx_end, index_op_desc_unique_together,
"Transaction end not found or found before operation description (unique_together)"
)
self.assertGreater( self.assertGreater(
index_op_desc_author, index_tx_start, index_op_desc_author, index_tx_start,
"Operation description (author) not found or found before transaction start" "Operation description (author) not found or found before transaction start"
@ -553,10 +559,6 @@ class MigrateTests(MigrationTestBase):
index_op_desc_unique_together, index_op_desc_tribble, index_op_desc_unique_together, index_op_desc_tribble,
"Operation description (unique_together) not found or found before operation description (tribble)" "Operation description (unique_together) not found or found before operation description (tribble)"
) )
self.assertGreater(
index_tx_end, index_op_desc_unique_together,
"Transaction end not found or found before operation description (unique_together)"
)
@override_settings(MIGRATION_MODULES={"migrations": "migrations.test_migrations"}) @override_settings(MIGRATION_MODULES={"migrations": "migrations.test_migrations"})
def test_sqlmigrate_backwards(self): def test_sqlmigrate_backwards(self):
@ -577,7 +579,12 @@ class MigrateTests(MigrationTestBase):
index_drop_table = output.rfind('drop table') index_drop_table = output.rfind('drop table')
index_tx_end = output.find(connection.ops.end_transaction_sql().lower()) index_tx_end = output.find(connection.ops.end_transaction_sql().lower())
self.assertGreater(index_tx_start, -1, "Transaction start not found") if connection.features.can_rollback_ddl:
self.assertGreater(index_tx_start, -1, "Transaction start not found")
self.assertGreater(
index_tx_end, index_op_desc_unique_together,
"Transaction end not found or found before DROP TABLE"
)
self.assertGreater( self.assertGreater(
index_op_desc_unique_together, index_tx_start, index_op_desc_unique_together, index_tx_start,
"Operation description (unique_together) not found or found before transaction start" "Operation description (unique_together) not found or found before transaction start"
@ -595,10 +602,6 @@ class MigrateTests(MigrationTestBase):
index_drop_table, index_op_desc_author, index_drop_table, index_op_desc_author,
"DROP TABLE not found or found before operation description (author)" "DROP TABLE not found or found before operation description (author)"
) )
self.assertGreater(
index_tx_end, index_op_desc_unique_together,
"Transaction end not found or found before DROP TABLE"
)
# Cleanup by unmigrating everything # Cleanup by unmigrating everything
call_command("migrate", "migrations", "zero", verbosity=0) call_command("migrate", "migrations", "zero", verbosity=0)
@ -616,6 +619,22 @@ class MigrateTests(MigrationTestBase):
self.assertNotIn(connection.ops.start_transaction_sql().lower(), queries) self.assertNotIn(connection.ops.start_transaction_sql().lower(), queries)
self.assertNotIn(connection.ops.end_transaction_sql().lower(), queries) self.assertNotIn(connection.ops.end_transaction_sql().lower(), queries)
@override_settings(MIGRATION_MODULES={'migrations': 'migrations.test_migrations'})
def test_sqlmigrate_for_non_transactional_databases(self):
"""
Transaction wrappers aren't shown for databases that don't support
transactional DDL.
"""
out = io.StringIO()
with mock.patch.object(connection.features, 'can_rollback_ddl', False):
call_command('sqlmigrate', 'migrations', '0001', stdout=out)
output = out.getvalue().lower()
queries = [q.strip() for q in output.splitlines()]
start_transaction_sql = connection.ops.start_transaction_sql()
if start_transaction_sql:
self.assertNotIn(start_transaction_sql.lower(), queries)
self.assertNotIn(connection.ops.end_transaction_sql().lower(), queries)
@override_settings( @override_settings(
INSTALLED_APPS=[ INSTALLED_APPS=[
"migrations.migrations_test_apps.migrated_app", "migrations.migrations_test_apps.migrated_app",