mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-06-05 19:49:13 +00:00
Code Issues 32 Releases Wiki Activity

[5.0.x] Refs #35359 -- Fixed OperationTests.test_add_generate_field() test on PostgreSQL.

Browse Source 
Concat() in Django 5.0 is not immutable on PostgreSQL and cannot be used
in GeneratedField, see 6364b6ee1071381eb3a23ba6b821fc0d6f0fce75.
This commit is contained in:
Sarah Boyce 2024-05-03 09:21:35 +02:00 committed by nessita
parent 59c3f8a539
commit ac9e18f1c4
1 changed files with 7 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
tests/migrations/test_operations.py
View File

@ -8,7 +8,7 @@ from django.db.migrations.operations.fields import FieldOperation
from django.db.migrations.state import ModelState, ProjectState from django.db.migrations.state import ModelState, ProjectState
from django.db.models import F from django.db.models import F
from django.db.models.expressions import Value from django.db.models.expressions import Value
from django.db.models.functions import Abs, Concat, Pi from django.db.models.functions import Abs, Pi
from django.db.transaction import atomic from django.db.transaction import atomic
from django.test import ( from django.test import (
SimpleTestCase, SimpleTestCase,
@ -1389,7 +1389,7 @@ class OperationTests(OperationTestBase):
"Pony", "Pony",
fields=[ fields=[
("id", models.AutoField(primary_key=True)), ("id", models.AutoField(primary_key=True)),
("name", models.CharField(max_length=20)), ("pink", models.IntegerField()),
( (
"rider", "rider",
models.ForeignKey( models.ForeignKey(
@ -1397,10 +1397,10 @@ class OperationTests(OperationTestBase):
), ),
), ),
( (
"name_and_id", "pink_plus_rider",
models.GeneratedField( models.GeneratedField(
expression=Concat(("name"), ("rider_id")), expression=F("pink") + F("rider_id"),
output_field=models.TextField(), output_field=models.IntegerField(),
db_persist=True, db_persist=True,
), ),
), ),
@ -1411,14 +1411,8 @@ class OperationTests(OperationTestBase):
Pony = project_state.apps.get_model(app_label, "Pony") Pony = project_state.apps.get_model(app_label, "Pony")
Rider = project_state.apps.get_model(app_label, "Rider") Rider = project_state.apps.get_model(app_label, "Rider")
rider = Rider.objects.create() rider = Rider.objects.create()
pony = Pony.objects.create(name="pony", rider=rider) pony = Pony.objects.create(pink=3, rider=rider)
self.assertEqual(pony.name_and_id, str(pony.name) + str(rider.id)) self.assertEqual(pony.pink_plus_rider, 3 + rider.id)
new_rider = Rider.objects.create()
pony.rider = new_rider
pony.save()
pony.refresh_from_db()
self.assertEqual(pony.name_and_id, str(pony.name) + str(new_rider.id))
def test_add_charfield(self): def test_add_charfield(self):
""" """