mirror of
https://github.com/django/django.git
synced 2024-12-22 17:16:24 +00:00
Fixed #35890 -- Fixed custom pre_save in fields from parents models not being called.
This commit is contained in:
parent
c2c544cf01
commit
a6687ed025
@ -992,7 +992,7 @@ class QuerySet(AltersData):
|
||||
# This is to maintain backward compatibility as these fields
|
||||
# are not updated unless explicitly specified in the
|
||||
# update_fields list.
|
||||
for field in self.model._meta.local_concrete_fields:
|
||||
for field in self.model._meta.concrete_fields:
|
||||
if not (
|
||||
field.primary_key or field.__class__.pre_save is Field.pre_save
|
||||
):
|
||||
|
@ -65,3 +65,7 @@ class Book(models.Model):
|
||||
db_column="publisher_id_column",
|
||||
)
|
||||
updated = models.DateTimeField(auto_now=True)
|
||||
|
||||
|
||||
class ComicBook(Book):
|
||||
pass
|
||||
|
@ -12,6 +12,7 @@ from django.utils.functional import lazy
|
||||
from .models import (
|
||||
Author,
|
||||
Book,
|
||||
ComicBook,
|
||||
DefaultPerson,
|
||||
Journalist,
|
||||
ManualPrimaryKeyTest,
|
||||
@ -579,12 +580,14 @@ class UpdateOrCreateTests(TestCase):
|
||||
|
||||
def test_update_only_defaults_and_pre_save_fields_when_local_fields(self):
|
||||
publisher = Publisher.objects.create(name="Acme Publishing")
|
||||
book = Book.objects.create(publisher=publisher, name="The Book of Ed & Fred")
|
||||
book = ComicBook.objects.create(
|
||||
publisher=publisher, name="The Book of Ed & Fred"
|
||||
)
|
||||
|
||||
for defaults in [{"publisher": publisher}, {"publisher_id": publisher}]:
|
||||
with self.subTest(defaults=defaults):
|
||||
with CaptureQueriesContext(connection) as captured_queries:
|
||||
book, created = Book.objects.update_or_create(
|
||||
book, created = ComicBook.objects.update_or_create(
|
||||
pk=book.pk,
|
||||
defaults=defaults,
|
||||
)
|
||||
|
Loading…
Reference in New Issue
Block a user