mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-10-26 23:26:08 +00:00
Code Issues 32 Releases Wiki Activity

[1.11.x] Fixed #28387 -- Fixed has_changed() for disabled form fields that subclass it.

Browse Source 
Backport of 5debbdfcc8 from master
This commit is contained in:
Srinivas Reddy Thatiparthy
2017-07-13 20:25:32 +05:30
committed by Tim Graham
parent fc6b90bdb7
commit a3b5df8ed5
8 changed files with 40 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/model_forms/tests.py
View File

@@ -1708,6 +1708,10 @@ class ModelChoiceFieldTests(TestCase):
['Select a valid choice. That choice is not one of the available choices.']
)
def test_disabled_modelchoicefield_has_changed(self):
field = forms.ModelChoiceField(Author.objects.all(), disabled=True)
self.assertIs(field.has_changed('x', 'y'), False)
def test_disabled_multiplemodelchoicefield(self):
class ArticleForm(forms.ModelForm):
categories = forms.ModelMultipleChoiceField(Category.objects.all(), required=False)
@@ -1733,6 +1737,10 @@ class ModelChoiceFieldTests(TestCase):
self.assertEqual(form.errors, {})
self.assertEqual([x.pk for x in form.cleaned_data['categories']], [category1.pk])
def test_disabled_modelmultiplechoicefield_has_changed(self):
field = forms.ModelMultipleChoiceField(Author.objects.all(), disabled=True)
self.assertIs(field.has_changed('x', 'y'), False)
def test_modelchoicefield_iterator(self):
"""
Iterator defaults to ModelChoiceIterator and can be overridden with