1
0
mirror of https://github.com/django/django.git synced 2025-07-04 01:39:20 +00:00

newforms-admin: Fixed #5374 -- Added validation for ModelAdmin and InlineModelAdmin options including tests. Thanks mrts for initial legwork.

git-svn-id: http://code.djangoproject.com/svn/django/branches/newforms-admin@7929 bcc190cf-cafb-0310-a4f2-bffc1f526a37
This commit is contained in:
Brian Rosner 2008-07-15 21:43:21 +00:00
parent affc9b9b3b
commit a2c7bfc1be
4 changed files with 828 additions and 66 deletions

View File

@ -7,6 +7,7 @@ from django.utils.safestring import mark_safe
from django.utils.text import capfirst from django.utils.text import capfirst
from django.utils.translation import ugettext_lazy, ugettext as _ from django.utils.translation import ugettext_lazy, ugettext as _
from django.views.decorators.cache import never_cache from django.views.decorators.cache import never_cache
from django.conf import settings
import base64 import base64
import cPickle as pickle import cPickle as pickle
import datetime import datetime
@ -65,6 +66,10 @@ class AdminSite(object):
If a model is already registered, this will raise AlreadyRegistered. If a model is already registered, this will raise AlreadyRegistered.
""" """
do_validate = admin_class and settings.DEBUG
if do_validate:
# don't import the humongous validation code unless required
from django.contrib.admin.validation import validate
admin_class = admin_class or ModelAdmin admin_class = admin_class or ModelAdmin
# TODO: Handle options # TODO: Handle options
if isinstance(model_or_iterable, ModelBase): if isinstance(model_or_iterable, ModelBase):
@ -72,6 +77,8 @@ class AdminSite(object):
for model in model_or_iterable: for model in model_or_iterable:
if model in self._registry: if model in self._registry:
raise AlreadyRegistered('The model %s is already registered' % model.__name__) raise AlreadyRegistered('The model %s is already registered' % model.__name__)
if do_validate:
validate(admin_class, model)
self._registry[model] = admin_class(model, self) self._registry[model] = admin_class(model, self)
def unregister(self, model_or_iterable): def unregister(self, model_or_iterable):

View File

@ -0,0 +1,254 @@
from django.core.exceptions import ImproperlyConfigured
from django.db import models
from django.newforms.models import BaseModelForm, BaseInlineFormset
from django.contrib.admin.options import flatten_fieldsets, BaseModelAdmin
from django.contrib.admin.options import HORIZONTAL, VERTICAL
def validate(cls, model):
"""
Does basic ModelAdmin option validation. Calls custom validation
classmethod in the end if it is provided in cls. The signature of the
custom validation classmethod should be: def validate(cls, model).
"""
opts = model._meta
_validate_base(cls, model)
# currying is expensive, use wrappers instead
def _check_istuplew(label, obj):
_check_istuple(cls, label, obj)
def _check_isdictw(label, obj):
_check_isdict(cls, label, obj)
def _check_field_existsw(label, field):
return _check_field_exists(cls, model, opts, label, field)
def _check_attr_existsw(label, field):
return _check_attr_exists(cls, model, opts, label, field)
# list_display
if hasattr(cls, 'list_display'):
_check_istuplew('list_display', cls.list_display)
for idx, field in enumerate(cls.list_display):
f = _check_attr_existsw("list_display[%d]" % idx, field)
if isinstance(f, models.ManyToManyField):
raise ImproperlyConfigured("`%s.list_display[%d]`, `%s` is a "
"ManyToManyField which is not supported."
% (cls.__name__, idx, field))
# list_display_links
if hasattr(cls, 'list_display_links'):
_check_istuplew('list_display_links', cls.list_display_links)
for idx, field in enumerate(cls.list_display_links):
_check_attr_existsw('list_display_links[%d]' % idx, field)
if field not in cls.list_display:
raise ImproperlyConfigured("`%s.list_display_links[%d]`"
"refers to `%s` which is not defined in `list_display`."
% (cls.__name__, idx, field))
# list_filter
if hasattr(cls, 'list_filter'):
_check_istuplew('list_filter', cls.list_filter)
for idx, field in enumerate(cls.list_filter):
_check_field_existsw('list_filter[%d]' % idx, field)
# list_per_page = 100
if hasattr(cls, 'list_per_page') and not isinstance(cls.list_per_page, int):
raise ImproperlyConfigured("`%s.list_per_page` should be a integer."
% cls.__name__)
# search_fields = ()
if hasattr(cls, 'search_fields'):
_check_istuplew('search_fields', cls.search_fields)
# date_hierarchy = None
if cls.date_hierarchy:
f = _check_field_existsw('date_hierarchy', cls.date_hierarchy)
if not isinstance(f, (models.DateField, models.DateTimeField)):
raise ImproperlyConfigured("`%s.date_hierarchy is "
"neither an instance of DateField nor DateTimeField."
% cls.__name__)
# ordering = None
if cls.ordering:
_check_istuplew('ordering', cls.ordering)
for idx, field in enumerate(cls.ordering):
if field == '?' and len(cls.ordering) != 1:
raise ImproperlyConfigured("`%s.ordering` has the random "
"ordering marker `?`, but contains other fields as "
"well. Please either remove `?` or the other fields."
% cls.__name__)
if field.startswith('-'):
field = field[1:]
_check_field_existsw('ordering[%d]' % idx, field)
# list_select_related = False
# save_as = False
# save_on_top = False
for attr in ('list_select_related', 'save_as', 'save_on_top'):
if not isinstance(getattr(cls, attr), bool):
raise ImproperlyConfigured("`%s.%s` should be a boolean."
% (cls.__name__, attr))
# inlines = []
if hasattr(cls, 'inlines'):
_check_istuplew('inlines', cls.inlines)
for idx, inline in enumerate(cls.inlines):
if not issubclass(inline, BaseModelAdmin):
raise ImproperlyConfigured("`%s.inlines[%d]` does not inherit "
"from BaseModelAdmin." % (cls.__name__, idx))
if not inline.model:
raise ImproperlyConfigured("`model` is a required attribute "
"of `%s.inlines[%d]`." % (cls.__name__, idx))
if not issubclass(inline.model, models.Model):
raise ImproperlyConfigured("`%s.inlines[%d].model` does not "
"inherit from models.Model." % (cls.__name__, idx))
_validate_base(inline, inline.model)
_validate_inline(inline)
def _validate_inline(cls):
# model is already verified to exist and be a Model
if cls.fk_name: # default value is None
f = _check_field_exists(cls, cls.model, cls.model._meta,
'fk_name', cls.fk_name)
if not isinstance(f, models.ForeignKey):
raise ImproperlyConfigured("`%s.fk_name is not an instance of "
"models.ForeignKey." % cls.__name__)
# extra = 3
# max_num = 0
for attr in ('extra', 'max_num'):
if not isinstance(getattr(cls, attr), int):
raise ImproperlyConfigured("`%s.%s` should be a integer."
% (cls.__name__, attr))
# formset
if hasattr(cls, 'formset') and not issubclass(cls.formset, BaseInlineFormset):
raise ImproperlyConfigured("`%s.formset` does not inherit from "
"BaseInlineFormset." % cls.__name__)
def _validate_base(cls, model):
opts = model._meta
# currying is expensive, use wrappers instead
def _check_istuplew(label, obj):
_check_istuple(cls, label, obj)
def _check_isdictw(label, obj):
_check_isdict(cls, label, obj)
def _check_field_existsw(label, field):
return _check_field_exists(cls, model, opts, label, field)
# raw_id_fields
if hasattr(cls, 'raw_id_fields'):
_check_istuplew('raw_id_fields', cls.raw_id_fields)
for idx, field in enumerate(cls.raw_id_fields):
f = _check_field_existsw('raw_id_fields', field)
if not isinstance(f, (models.ForeignKey, models.ManyToManyField)):
raise ImproperlyConfigured("`%s.raw_id_fields[%d]`, `%s` must "
"be either a ForeignKey or ManyToManyField."
% (cls.__name__, idx, field))
# fields
if cls.fields: # default value is None
_check_istuplew('fields', cls.fields)
for field in cls.fields:
_check_field_existsw('fields', field)
# fieldsets
if cls.fieldsets: # default value is None
_check_istuplew('fieldsets', cls.fieldsets)
for idx, fieldset in enumerate(cls.fieldsets):
_check_istuplew('fieldsets[%d]' % idx, fieldset)
if len(fieldset) != 2:
raise ImproperlyConfigured("`%s.fieldsets[%d]` does not "
"have exactly two elements." % (cls.__name__, idx))
_check_isdictw('fieldsets[%d][1]' % idx, fieldset[1])
if 'fields' not in fieldset[1]:
raise ImproperlyConfigured("`fields` key is required in "
"%s.fieldsets[%d][1] field options dict."
% (cls.__name__, idx))
for field in flatten_fieldsets(cls.fieldsets):
_check_field_existsw("fieldsets[%d][1]['fields']" % idx, field)
# form
if hasattr(cls, 'form') and not issubclass(cls.form, BaseModelForm):
raise ImproperlyConfigured("%s.form does not inherit from "
"BaseModelForm." % cls.__name__)
# filter_vertical
if hasattr(cls, 'filter_vertical'):
_check_istuplew('filter_vertical', cls.filter_vertical)
for idx, field in enumerate(cls.filter_vertical):
f = _check_field_existsw('filter_vertical', field)
if not isinstance(f, models.ManyToManyField):
raise ImproperlyConfigured("`%s.filter_vertical[%d]` must be "
"a ManyToManyField." % (cls.__name__, idx))
# filter_horizontal
if hasattr(cls, 'filter_horizontal'):
_check_istuplew('filter_horizontal', cls.filter_horizontal)
for idx, field in enumerate(cls.filter_horizontal):
f = _check_field_existsw('filter_horizontal', field)
if not isinstance(f, models.ManyToManyField):
raise ImproperlyConfigured("`%s.filter_horizontal[%d]` must be "
"a ManyToManyField." % (cls.__name__, idx))
# radio_fields
if hasattr(cls, 'radio_fields'):
_check_isdictw('radio_fields', cls.radio_fields)
for field, val in cls.radio_fields.items():
f = _check_field_existsw('radio_fields', field)
if not (isinstance(f, models.ForeignKey) or f.choices):
raise ImproperlyConfigured("`%s.radio_fields['%s']` "
"is neither an instance of ForeignKey nor does "
"have choices set." % (cls.__name__, field))
if not val in (HORIZONTAL, VERTICAL):
raise ImproperlyConfigured("`%s.radio_fields['%s']` "
"is neither admin.HORIZONTAL nor admin.VERTICAL."
% (cls.__name__, field))
# prepopulated_fields
if hasattr(cls, 'prepopulated_fields'):
_check_isdictw('prepopulated_fields', cls.prepopulated_fields)
for field, val in cls.prepopulated_fields.items():
f = _check_field_existsw('prepopulated_fields', field)
if isinstance(f, (models.DateTimeField, models.ForeignKey,
models.ManyToManyField)):
raise ImproperlyConfigured("`%s.prepopulated_fields['%s']` "
"is either a DateTimeField, ForeignKey or "
"ManyToManyField. This isn't allowed."
% (cls.__name__, field))
_check_istuplew("prepopulated_fields['%s']" % field, val)
for idx, f in enumerate(val):
_check_field_existsw("prepopulated_fields['%s'][%d]"
% (f, idx), f)
def _check_istuple(cls, label, obj):
if not isinstance(obj, (list, tuple)):
raise ImproperlyConfigured("`%s.%s` must be a "
"list or tuple." % (cls.__name__, label))
def _check_isdict(cls, label, obj):
if not isinstance(obj, dict):
raise ImproperlyConfigured("`%s.%s` must be a dictionary."
% (cls.__name__, label))
def _check_field_exists(cls, model, opts, label, field):
try:
return opts.get_field(field)
except models.FieldDoesNotExist:
raise ImproperlyConfigured("`%s.%s` refers to "
"field `%s` that is missing from model `%s`."
% (cls.__name__, label, field, model.__name__))
def _check_attr_exists(cls, model, opts, label, field):
try:
return opts.get_field(field)
except models.FieldDoesNotExist:
if not hasattr(model, field):
raise ImproperlyConfigured("`%s.%s` refers to "
"`%s` that is neither a field, method or property "
"of model `%s`."
% (cls.__name__, label, field, model.__name__))
return getattr(model, field)

View File

@ -143,59 +143,6 @@ def get_validation_errors(outfile, app=None):
if r.get_accessor_name() == rel_query_name: if r.get_accessor_name() == rel_query_name:
e.add(opts, "Reverse query name for m2m field '%s' clashes with related field '%s.%s'. Add a related_name argument to the definition for '%s'." % (f.name, rel_opts.object_name, r.get_accessor_name(), f.name)) e.add(opts, "Reverse query name for m2m field '%s' clashes with related field '%s.%s'. Add a related_name argument to the definition for '%s'." % (f.name, rel_opts.object_name, r.get_accessor_name(), f.name))
# Check admin attribute.
if opts.admin is not None:
# prepopulated_fields
if not isinstance(opts.admin.prepopulated_fields, dict):
e.add(opts, '"%s": prepopulated_fields should be a dictionary.' % f.name)
else:
for field_name, field_list in opts.admin.prepopulated_fields.items():
if not isinstance(field_list, (list, tuple)):
e.add(opts, '"%s": prepopulated_fields "%s" value should be a list or tuple.' % (f.name, field_name))
# list_display
if not isinstance(opts.admin.list_display, (list, tuple)):
e.add(opts, '"admin.list_display", if given, must be set to a list or tuple.')
else:
for fn in opts.admin.list_display:
try:
f = opts.get_field(fn)
except models.FieldDoesNotExist:
if not hasattr(cls, fn):
e.add(opts, '"admin.list_display" refers to %r, which isn\'t an attribute, method or property.' % fn)
else:
if isinstance(f, models.ManyToManyField):
e.add(opts, '"admin.list_display" doesn\'t support ManyToManyFields (%r).' % fn)
# list_display_links
if opts.admin.list_display_links and not opts.admin.list_display:
e.add(opts, '"admin.list_display" must be defined for "admin.list_display_links" to be used.')
if not isinstance(opts.admin.list_display_links, (list, tuple)):
e.add(opts, '"admin.list_display_links", if given, must be set to a list or tuple.')
else:
for fn in opts.admin.list_display_links:
try:
f = opts.get_field(fn)
except models.FieldDoesNotExist:
if not hasattr(cls, fn):
e.add(opts, '"admin.list_display_links" refers to %r, which isn\'t an attribute, method or property.' % fn)
if fn not in opts.admin.list_display:
e.add(opts, '"admin.list_display_links" refers to %r, which is not defined in "admin.list_display".' % fn)
# list_filter
if not isinstance(opts.admin.list_filter, (list, tuple)):
e.add(opts, '"admin.list_filter", if given, must be set to a list or tuple.')
else:
for fn in opts.admin.list_filter:
try:
f = opts.get_field(fn)
except models.FieldDoesNotExist:
e.add(opts, '"admin.list_filter" refers to %r, which isn\'t a field.' % fn)
# date_hierarchy
if opts.admin.date_hierarchy:
try:
f = opts.get_field(opts.admin.date_hierarchy)
except models.FieldDoesNotExist:
e.add(opts, '"admin.date_hierarchy" refers to %r, which isn\'t a field.' % opts.admin.date_hierarchy)
# Check ordering attribute. # Check ordering attribute.
if opts.ordering: if opts.ordering:
for field_name in opts.ordering: for field_name in opts.ordering:
@ -213,18 +160,6 @@ def get_validation_errors(outfile, app=None):
except models.FieldDoesNotExist: except models.FieldDoesNotExist:
e.add(opts, '"ordering" refers to "%s", a field that doesn\'t exist.' % field_name) e.add(opts, '"ordering" refers to "%s", a field that doesn\'t exist.' % field_name)
# Check core=True, if needed.
for related in opts.get_followed_related_objects():
if not related.edit_inline:
continue
try:
for f in related.opts.fields:
if f.core:
raise StopIteration
e.add(related.opts, "At least one field in %s should have core=True, because it's being edited inline by %s.%s." % (related.opts.object_name, opts.module_name, opts.object_name))
except StopIteration:
pass
# Check unique_together. # Check unique_together.
for ut in opts.unique_together: for ut in opts.unique_together:
for field_name in ut: for field_name in ut:

View File

@ -1,7 +1,9 @@
# coding: utf-8 # coding: utf-8
from django.db import models
from datetime import date from datetime import date
from django.db import models
from django.contrib.auth.models import User
class Band(models.Model): class Band(models.Model):
name = models.CharField(max_length=100) name = models.CharField(max_length=100)
bio = models.TextField() bio = models.TextField()
@ -21,6 +23,16 @@ class Concert(models.Model):
(3, 'Bus') (3, 'Bus')
), blank=True) ), blank=True)
class ValidationTestModel(models.Model):
name = models.CharField(max_length=100)
slug = models.SlugField()
users = models.ManyToManyField(User)
state = models.CharField(max_length=2, choices=(("CO", "Colorado"), ("WA", "Washington")))
is_active = models.BooleanField()
pub_date = models.DateTimeField()
class ValidationTestInlineModel(models.Model):
parent = models.ForeignKey(ValidationTestModel)
__test__ = {'API_TESTS': """ __test__ = {'API_TESTS': """
@ -226,5 +238,559 @@ blank=True for the model field. Finally, the widget should have the
>>> band.delete() >>> band.delete()
# ModelAdmin Option Validation ################################################
>>> from django.contrib.admin.validation import validate
>>> from django.conf import settings
# Ensure validation only runs when DEBUG = True
>>> settings.DEBUG = True
>>> class ValidationTestModelAdmin(ModelAdmin):
... raw_id_fields = 10
>>> site = AdminSite()
>>> site.register(ValidationTestModel, ValidationTestModelAdmin)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestModelAdmin.raw_id_fields` must be a list or tuple.
>>> settings.DEBUG = False
>>> class ValidationTestModelAdmin(ModelAdmin):
... raw_id_fields = 10
>>> site = AdminSite()
>>> site.register(ValidationTestModel, ValidationTestModelAdmin)
# raw_id_fields
>>> class ValidationTestModelAdmin(ModelAdmin):
... raw_id_fields = 10
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestModelAdmin.raw_id_fields` must be a list or tuple.
>>> class ValidationTestModelAdmin(ModelAdmin):
... raw_id_fields = ('non_existent_field',)
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestModelAdmin.raw_id_fields` refers to field `non_existent_field` that is missing from model `ValidationTestModel`.
>>> class ValidationTestModelAdmin(ModelAdmin):
... raw_id_fields = ('name',)
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestModelAdmin.raw_id_fields[0]`, `name` must be either a ForeignKey or ManyToManyField.
>>> class ValidationTestModelAdmin(ModelAdmin):
... raw_id_fields = ('users',)
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
# fieldsets
>>> class ValidationTestModelAdmin(ModelAdmin):
... fieldsets = 10
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestModelAdmin.fieldsets` must be a list or tuple.
>>> class ValidationTestModelAdmin(ModelAdmin):
... fieldsets = ({},)
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestModelAdmin.fieldsets[0]` must be a list or tuple.
>>> class ValidationTestModelAdmin(ModelAdmin):
... fieldsets = ((),)
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestModelAdmin.fieldsets[0]` does not have exactly two elements.
>>> class ValidationTestModelAdmin(ModelAdmin):
... fieldsets = (("General", ()),)
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestModelAdmin.fieldsets[0][1]` must be a dictionary.
>>> class ValidationTestModelAdmin(ModelAdmin):
... fieldsets = (("General", {}),)
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `fields` key is required in ValidationTestModelAdmin.fieldsets[0][1] field options dict.
>>> class ValidationTestModelAdmin(ModelAdmin):
... fieldsets = (("General", {"fields": ("non_existent_field",)}),)
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestModelAdmin.fieldsets[0][1]['fields']` refers to field `non_existent_field` that is missing from model `ValidationTestModel`.
>>> class ValidationTestModelAdmin(ModelAdmin):
... fieldsets = (("General", {"fields": ("name",)}),)
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
# form
>>> class FakeForm(object):
... pass
>>> class ValidationTestModelAdmin(ModelAdmin):
... form = FakeForm
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: ValidationTestModelAdmin.form does not inherit from BaseModelForm.
# filter_vertical
>>> class ValidationTestModelAdmin(ModelAdmin):
... filter_vertical = 10
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestModelAdmin.filter_vertical` must be a list or tuple.
>>> class ValidationTestModelAdmin(ModelAdmin):
... filter_vertical = ("non_existent_field",)
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestModelAdmin.filter_vertical` refers to field `non_existent_field` that is missing from model `ValidationTestModel`.
>>> class ValidationTestModelAdmin(ModelAdmin):
... filter_vertical = ("name",)
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestModelAdmin.filter_vertical[0]` must be a ManyToManyField.
>>> class ValidationTestModelAdmin(ModelAdmin):
... filter_vertical = ("users",)
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
# filter_horizontal
>>> class ValidationTestModelAdmin(ModelAdmin):
... filter_horizontal = 10
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestModelAdmin.filter_horizontal` must be a list or tuple.
>>> class ValidationTestModelAdmin(ModelAdmin):
... filter_horizontal = ("non_existent_field",)
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestModelAdmin.filter_horizontal` refers to field `non_existent_field` that is missing from model `ValidationTestModel`.
>>> class ValidationTestModelAdmin(ModelAdmin):
... filter_horizontal = ("name",)
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestModelAdmin.filter_horizontal[0]` must be a ManyToManyField.
>>> class ValidationTestModelAdmin(ModelAdmin):
... filter_horizontal = ("users",)
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
# radio_fields
>>> class ValidationTestModelAdmin(ModelAdmin):
... radio_fields = ()
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestModelAdmin.radio_fields` must be a dictionary.
>>> class ValidationTestModelAdmin(ModelAdmin):
... radio_fields = {"non_existent_field": None}
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestModelAdmin.radio_fields` refers to field `non_existent_field` that is missing from model `ValidationTestModel`.
>>> class ValidationTestModelAdmin(ModelAdmin):
... radio_fields = {"name": None}
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestModelAdmin.radio_fields['name']` is neither an instance of ForeignKey nor does have choices set.
>>> class ValidationTestModelAdmin(ModelAdmin):
... radio_fields = {"state": None}
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestModelAdmin.radio_fields['state']` is neither admin.HORIZONTAL nor admin.VERTICAL.
>>> class ValidationTestModelAdmin(ModelAdmin):
... radio_fields = {"state": VERTICAL}
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
# prepopulated_fields
>>> class ValidationTestModelAdmin(ModelAdmin):
... prepopulated_fields = ()
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestModelAdmin.prepopulated_fields` must be a dictionary.
>>> class ValidationTestModelAdmin(ModelAdmin):
... prepopulated_fields = {"non_existent_field": None}
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestModelAdmin.prepopulated_fields` refers to field `non_existent_field` that is missing from model `ValidationTestModel`.
>>> class ValidationTestModelAdmin(ModelAdmin):
... prepopulated_fields = {"slug": ("non_existent_field",)}
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestModelAdmin.prepopulated_fields['non_existent_field'][0]` refers to field `non_existent_field` that is missing from model `ValidationTestModel`.
>>> class ValidationTestModelAdmin(ModelAdmin):
... prepopulated_fields = {"users": ("name",)}
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestModelAdmin.prepopulated_fields['users']` is either a DateTimeField, ForeignKey or ManyToManyField. This isn't allowed.
>>> class ValidationTestModelAdmin(ModelAdmin):
... prepopulated_fields = {"slug": ("name",)}
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
# list_display
>>> class ValidationTestModelAdmin(ModelAdmin):
... list_display = 10
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestModelAdmin.list_display` must be a list or tuple.
>>> class ValidationTestModelAdmin(ModelAdmin):
... list_display = ('non_existent_field',)
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestModelAdmin.list_display[0]` refers to `non_existent_field` that is neither a field, method or property of model `ValidationTestModel`.
>>> class ValidationTestModelAdmin(ModelAdmin):
... list_display = ('users',)
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestModelAdmin.list_display[0]`, `users` is a ManyToManyField which is not supported.
>>> class ValidationTestModelAdmin(ModelAdmin):
... list_display = ('name',)
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
# list_display_links
>>> class ValidationTestModelAdmin(ModelAdmin):
... list_display_links = 10
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestModelAdmin.list_display_links` must be a list or tuple.
>>> class ValidationTestModelAdmin(ModelAdmin):
... list_display_links = ('non_existent_field',)
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestModelAdmin.list_display_links[0]` refers to `non_existent_field` that is neither a field, method or property of model `ValidationTestModel`.
>>> class ValidationTestModelAdmin(ModelAdmin):
... list_display_links = ('name',)
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestModelAdmin.list_display_links[0]`refers to `name` which is not defined in `list_display`.
>>> class ValidationTestModelAdmin(ModelAdmin):
... list_display = ('name',)
... list_display_links = ('name',)
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
# list_filter
>>> class ValidationTestModelAdmin(ModelAdmin):
... list_filter = 10
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestModelAdmin.list_filter` must be a list or tuple.
>>> class ValidationTestModelAdmin(ModelAdmin):
... list_filter = ('non_existent_field',)
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestModelAdmin.list_filter[0]` refers to field `non_existent_field` that is missing from model `ValidationTestModel`.
>>> class ValidationTestModelAdmin(ModelAdmin):
... list_filter = ('is_active',)
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
# list_per_page
>>> class ValidationTestModelAdmin(ModelAdmin):
... list_per_page = 'hello'
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestModelAdmin.list_per_page` should be a integer.
>>> class ValidationTestModelAdmin(ModelAdmin):
... list_per_page = 100
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
# search_fields
>>> class ValidationTestModelAdmin(ModelAdmin):
... search_fields = 10
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestModelAdmin.search_fields` must be a list or tuple.
# date_hierarchy
>>> class ValidationTestModelAdmin(ModelAdmin):
... date_hierarchy = 'non_existent_field'
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestModelAdmin.date_hierarchy` refers to field `non_existent_field` that is missing from model `ValidationTestModel`.
>>> class ValidationTestModelAdmin(ModelAdmin):
... date_hierarchy = 'name'
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestModelAdmin.date_hierarchy is neither an instance of DateField nor DateTimeField.
>>> class ValidationTestModelAdmin(ModelAdmin):
... date_hierarchy = 'pub_date'
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
# ordering
>>> class ValidationTestModelAdmin(ModelAdmin):
... ordering = 10
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestModelAdmin.ordering` must be a list or tuple.
>>> class ValidationTestModelAdmin(ModelAdmin):
... ordering = ('non_existent_field',)
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestModelAdmin.ordering[0]` refers to field `non_existent_field` that is missing from model `ValidationTestModel`.
>>> class ValidationTestModelAdmin(ModelAdmin):
... ordering = ('?', 'name')
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestModelAdmin.ordering` has the random ordering marker `?`, but contains other fields as well. Please either remove `?` or the other fields.
>>> class ValidationTestModelAdmin(ModelAdmin):
... ordering = ('name',)
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
# list_select_related
>>> class ValidationTestModelAdmin(ModelAdmin):
... list_select_related = 1
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestModelAdmin.list_select_related` should be a boolean.
>>> class ValidationTestModelAdmin(ModelAdmin):
... list_select_related = False
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
# save_as
>>> class ValidationTestModelAdmin(ModelAdmin):
... save_as = 1
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestModelAdmin.save_as` should be a boolean.
>>> class ValidationTestModelAdmin(ModelAdmin):
... save_as = True
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
# save_on_top
>>> class ValidationTestModelAdmin(ModelAdmin):
... save_on_top = 1
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestModelAdmin.save_on_top` should be a boolean.
>>> class ValidationTestModelAdmin(ModelAdmin):
... save_on_top = True
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
# inlines
>>> from django.contrib.admin.options import TabularInline
>>> class ValidationTestModelAdmin(ModelAdmin):
... inlines = 10
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestModelAdmin.inlines` must be a list or tuple.
>>> class ValidationTestInline(object):
... pass
>>> class ValidationTestModelAdmin(ModelAdmin):
... inlines = [ValidationTestInline]
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestModelAdmin.inlines[0]` does not inherit from BaseModelAdmin.
>>> class ValidationTestInline(TabularInline):
... pass
>>> class ValidationTestModelAdmin(ModelAdmin):
... inlines = [ValidationTestInline]
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `model` is a required attribute of `ValidationTestModelAdmin.inlines[0]`.
>>> class SomethingBad(object):
... pass
>>> class ValidationTestInline(TabularInline):
... model = SomethingBad
>>> class ValidationTestModelAdmin(ModelAdmin):
... inlines = [ValidationTestInline]
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestModelAdmin.inlines[0].model` does not inherit from models.Model.
>>> class ValidationTestInline(TabularInline):
... model = ValidationTestInlineModel
>>> class ValidationTestModelAdmin(ModelAdmin):
... inlines = [ValidationTestInline]
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
# fields
>>> class ValidationTestInline(TabularInline):
... model = ValidationTestInlineModel
... fields = 10
>>> class ValidationTestModelAdmin(ModelAdmin):
... inlines = [ValidationTestInline]
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestInline.fields` must be a list or tuple.
>>> class ValidationTestInline(TabularInline):
... model = ValidationTestInlineModel
... fields = ("non_existent_field",)
>>> class ValidationTestModelAdmin(ModelAdmin):
... inlines = [ValidationTestInline]
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestInline.fields` refers to field `non_existent_field` that is missing from model `ValidationTestInlineModel`.
# fk_name
>>> class ValidationTestInline(TabularInline):
... model = ValidationTestInlineModel
... fk_name = "non_existent_field"
>>> class ValidationTestModelAdmin(ModelAdmin):
... inlines = [ValidationTestInline]
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestInline.fk_name` refers to field `non_existent_field` that is missing from model `ValidationTestInlineModel`.
>>> class ValidationTestInline(TabularInline):
... model = ValidationTestInlineModel
... fk_name = "parent"
>>> class ValidationTestModelAdmin(ModelAdmin):
... inlines = [ValidationTestInline]
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
# extra
>>> class ValidationTestInline(TabularInline):
... model = ValidationTestInlineModel
... extra = "hello"
>>> class ValidationTestModelAdmin(ModelAdmin):
... inlines = [ValidationTestInline]
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestInline.extra` should be a integer.
>>> class ValidationTestInline(TabularInline):
... model = ValidationTestInlineModel
... extra = 2
>>> class ValidationTestModelAdmin(ModelAdmin):
... inlines = [ValidationTestInline]
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
# max_num
>>> class ValidationTestInline(TabularInline):
... model = ValidationTestInlineModel
... max_num = "hello"
>>> class ValidationTestModelAdmin(ModelAdmin):
... inlines = [ValidationTestInline]
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestInline.max_num` should be a integer.
>>> class ValidationTestInline(TabularInline):
... model = ValidationTestInlineModel
... max_num = 2
>>> class ValidationTestModelAdmin(ModelAdmin):
... inlines = [ValidationTestInline]
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
# formset
>>> class FakeFormSet(object):
... pass
>>> class ValidationTestInline(TabularInline):
... model = ValidationTestInlineModel
... formset = FakeFormSet
>>> class ValidationTestModelAdmin(ModelAdmin):
... inlines = [ValidationTestInline]
>>> validate(ValidationTestModelAdmin, ValidationTestModel)
Traceback (most recent call last):
...
ImproperlyConfigured: `ValidationTestInline.formset` does not inherit from BaseInlineFormset.
""" """
} }