mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-08-11 04:19:11 +00:00
Code Issues 32 Releases Wiki Activity

Fixed #35051 -- Prevented runserver from removing non-zero Content-Length for HEAD requests.

Browse Source
This commit is contained in:
Paul Bailey 2023-12-31 01:32:37 -06:00 committed by GitHub
parent dc26a3d563
commit 9d52e0720f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 40 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
django/core/servers/basehttp.py
View File

@ -134,6 +134,7 @@ class ServerHandler(simple_server.ServerHandler):
if ( if (
self.environ["REQUEST_METHOD"] == "HEAD" self.environ["REQUEST_METHOD"] == "HEAD"
and "Content-Length" in self.headers and "Content-Length" in self.headers
and str(self.headers["Content-Length"]) == "0"
): ):
del self.headers["Content-Length"] del self.headers["Content-Length"]
# HTTP/1.1 requires support for persistent connections. Send 'close' if # HTTP/1.1 requires support for persistent connections. Send 'close' if

39
tests/servers/test_basehttp.py
View File

@ -161,6 +161,45 @@ class WSGIRequestHandlerTestCase(SimpleTestCase):
) )
self.assertNotIn(b"Connection: close\r\n", lines) self.assertNotIn(b"Connection: close\r\n", lines)
def test_non_zero_content_length_set_head_request(self):
hello_world_body = b"<!DOCTYPE html><html><body>Hello World</body></html>"
content_length = len(hello_world_body)
def test_app(environ, start_response):
"""
A WSGI app that returns a hello world with non-zero Content-Length.
"""
start_response("200 OK", [("Content-length", str(content_length))])
return [hello_world_body]
rfile = BytesIO(b"HEAD / HTTP/1.0\r\n")
rfile.seek(0)
wfile = UnclosableBytesIO()
def makefile(mode, *a, **kw):
if mode == "rb":
return rfile
elif mode == "wb":
return wfile
request = Stub(makefile=makefile)
server = Stub(base_environ={}, get_app=lambda: test_app)
# Prevent logging from appearing in test output.
with self.assertLogs("django.server", "INFO"):
# Instantiating a handler runs the request as side effect.
WSGIRequestHandler(request, "192.168.0.2", server)
wfile.seek(0)
lines = list(wfile.readlines())
body = lines[-1]
# The body is not returned in a HEAD response.
self.assertEqual(body, b"\r\n")
# Non-zero Content-Length is not removed.
self.assertEqual(lines[-2], f"Content-length: {content_length}\r\n".encode())
self.assertNotIn(b"Connection: close\r\n", lines)
class WSGIServerTestCase(SimpleTestCase): class WSGIServerTestCase(SimpleTestCase):
request_factory = RequestFactory() request_factory = RequestFactory()