mirror of
https://github.com/django/django.git
synced 2025-10-24 14:16:09 +00:00
Fixed #26601 -- Improved middleware per DEP 0005.
Thanks Tim Graham for polishing the patch, updating the tests, and writing documentation. Thanks Carl Meyer for shepherding the DEP.
This commit is contained in:
committed by
Tim Graham
parent
05c888ffb8
commit
9baf692a58
@@ -1,8 +1,9 @@
|
||||
from django import http
|
||||
from django.conf import settings
|
||||
from django.utils.deprecation import MiddlewareMixin
|
||||
|
||||
|
||||
class XViewMiddleware(object):
|
||||
class XViewMiddleware(MiddlewareMixin):
|
||||
"""
|
||||
Adds an X-View header to internal HEAD requests -- used by the documentation system.
|
||||
"""
|
||||
@@ -15,8 +16,11 @@ class XViewMiddleware(object):
|
||||
"""
|
||||
assert hasattr(request, 'user'), (
|
||||
"The XView middleware requires authentication middleware to be "
|
||||
"installed. Edit your MIDDLEWARE_CLASSES setting to insert "
|
||||
"'django.contrib.auth.middleware.AuthenticationMiddleware'.")
|
||||
"installed. Edit your MIDDLEWARE%s setting to insert "
|
||||
"'django.contrib.auth.middleware.AuthenticationMiddleware'." % (
|
||||
"_CLASSES" if settings.MIDDLEWARE is None else ""
|
||||
)
|
||||
)
|
||||
if request.method == 'HEAD' and (request.META.get('REMOTE_ADDR') in settings.INTERNAL_IPS or
|
||||
(request.user.is_active and request.user.is_staff)):
|
||||
response = http.HttpResponse()
|
||||
|
||||
Reference in New Issue
Block a user