mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-06-16 00:49:12 +00:00
Code Issues 32 Releases Wiki Activity

Remove test database connection check

Browse Source 
It doesn't work well with multiple databases configured
This commit is contained in:
Jake Howard 2024-09-27 14:02:47 +01:00
parent 23a316529d
commit 975fbdfbe8
No known key found for this signature in database
GPG Key ID: 57AFB45680EDD477
3 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
django/tasks/backends/base.py
View File

@ -9,7 +9,6 @@ from django.tasks import DEFAULT_QUEUE_NAME
from django.tasks.exceptions import InvalidTaskError from django.tasks.exceptions import InvalidTaskError
from django.tasks.task import MAX_PRIORITY, MIN_PRIORITY, Task from django.tasks.task import MAX_PRIORITY, MIN_PRIORITY, Task
from django.tasks.utils import is_global_function from django.tasks.utils import is_global_function
from django.test.testcases import _DatabaseFailure
from django.utils import timezone from django.utils import timezone
@ -40,11 +39,6 @@ class BaseTaskBackend(metaclass=ABCMeta):
if not connections.settings: if not connections.settings:
return False return False
# If connections are disabled during tests, there's nothing to commit to
for conn in connections.all():
if isinstance(conn.connect, _DatabaseFailure):
return False
if isinstance(task.enqueue_on_commit, bool): if isinstance(task.enqueue_on_commit, bool):
return task.enqueue_on_commit return task.enqueue_on_commit

4
tests/tasks/test_dummy_backend.py
View File

@ -99,7 +99,7 @@ class DummyBackendTestCase(SimpleTestCase):
await default_task_backend.aget_result("123") await default_task_backend.aget_result("123")
def test_enqueue_on_commit(self): def test_enqueue_on_commit(self):
self.assertFalse( self.assertTrue(
default_task_backend._get_enqueue_on_commit_for_task( default_task_backend._get_enqueue_on_commit_for_task(
test_tasks.enqueue_on_commit_task test_tasks.enqueue_on_commit_task
) )
@ -115,6 +115,8 @@ class DummyBackendTestCase(SimpleTestCase):
class DummyBackendTransactionTestCase(TransactionTestCase): class DummyBackendTransactionTestCase(TransactionTestCase):
available_apps = []
@override_settings( @override_settings(
TASKS={ TASKS={
"default": { "default": {

4
tests/tasks/test_immediate_backend.py
View File

@ -171,7 +171,7 @@ class ImmediateBackendTestCase(SimpleTestCase):
) )
def test_enqueue_on_commit(self): def test_enqueue_on_commit(self):
self.assertFalse( self.assertTrue(
default_task_backend._get_enqueue_on_commit_for_task( default_task_backend._get_enqueue_on_commit_for_task(
test_tasks.enqueue_on_commit_task test_tasks.enqueue_on_commit_task
) )
@ -186,6 +186,8 @@ class ImmediateBackendTestCase(SimpleTestCase):
class ImmediateBackendTransactionTestCase(TransactionTestCase): class ImmediateBackendTransactionTestCase(TransactionTestCase):
available_apps = []
@override_settings( @override_settings(
TASKS={ TASKS={
"default": { "default": {