mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2024-12-22 17:16:24 +00:00
Code Issues 25 Releases Wiki Activity

Avoided isinstance(…, Variable) calls in FilterExpression.resolve().

Browse Source 
By determining the variable type within __init__() instead of resolve() 
we can skip an isinstance() check at template runtime. Templates are
executed in production more often than the parse trees themselves,
assuming the cached Loader is used.
This commit is contained in:
Keryn Knight 2022-01-07 09:29:22 +00:00 committed by GitHub
parent c67e1cf44f
commit 96e7ff5e9f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
django/template/base.py
View File

@ -694,9 +694,10 @@ class FilterExpression:
self.filters = filters
self.var = var_obj
self.is_var = isinstance(var_obj, Variable)
def resolve(self, context, ignore_failures=False):
if isinstance(self.var, Variable):
if self.is_var:
try:
obj = self.var.resolve(context)
except VariableDoesNotExist:

1
django/templatetags/i18n.py
View File

@ -77,6 +77,7 @@ class TranslateNode(Node):
self.message_context = message_context
self.filter_expression = filter_expression
if isinstance(self.filter_expression.var, str):
self.filter_expression.is_var = True
self.filter_expression.var = Variable("'%s'" %
self.filter_expression.var)