mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2024-12-22 17:16:24 +00:00
Code Issues 25 Releases Wiki Activity

Made SeleniumTests.test_updating_related_objects_updates_fk_selects_except_autocompletes() test less flaky by adding explicit Selenium wait.

Browse Source
This commit is contained in:
Sarah Boyce 2023-07-04 13:31:50 +02:00 committed by Mariusz Felisiak
parent adfb3dfa89
commit 968684aed4
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
tests/admin_views/tests.py
View File

@ -6437,6 +6437,7 @@ class SeleniumTests(AdminSeleniumTestCase):
) )
continent_select.select_by_visible_text("South America") continent_select.select_by_visible_text("South America")
self.selenium.find_element(By.CSS_SELECTOR, '[type="submit"]').click() self.selenium.find_element(By.CSS_SELECTOR, '[type="submit"]').click()
self.wait_until(lambda d: len(d.window_handles) == 1, 1)
self.selenium.switch_to.window(self.selenium.window_handles[0]) self.selenium.switch_to.window(self.selenium.window_handles[0])
self.assertHTMLEqual( self.assertHTMLEqual(
@ -6473,6 +6474,7 @@ class SeleniumTests(AdminSeleniumTestCase):
) )
continent_select.select_by_visible_text("Europe") continent_select.select_by_visible_text("Europe")
self.selenium.find_element(By.CSS_SELECTOR, '[type="submit"]').click() self.selenium.find_element(By.CSS_SELECTOR, '[type="submit"]').click()
self.wait_until(lambda d: len(d.window_handles) == 1, 1)
self.selenium.switch_to.window(self.selenium.window_handles[0]) self.selenium.switch_to.window(self.selenium.window_handles[0])
self.assertHTMLEqual( self.assertHTMLEqual(
@ -6514,6 +6516,7 @@ class SeleniumTests(AdminSeleniumTestCase):
favorite_name_input.clear() favorite_name_input.clear()
favorite_name_input.send_keys("Italy") favorite_name_input.send_keys("Italy")
self.selenium.find_element(By.CSS_SELECTOR, '[type="submit"]').click() self.selenium.find_element(By.CSS_SELECTOR, '[type="submit"]').click()
self.wait_until(lambda d: len(d.window_handles) == 1, 1)
self.selenium.switch_to.window(self.selenium.window_handles[0]) self.selenium.switch_to.window(self.selenium.window_handles[0])
self.assertHTMLEqual( self.assertHTMLEqual(
@ -6554,10 +6557,12 @@ class SeleniumTests(AdminSeleniumTestCase):
) )
continent_select.select_by_visible_text("Asia") continent_select.select_by_visible_text("Asia")
self.selenium.find_element(By.CSS_SELECTOR, '[type="submit"]').click() self.selenium.find_element(By.CSS_SELECTOR, '[type="submit"]').click()
self.wait_until(lambda d: len(d.window_handles) == 1, 1)
self.selenium.switch_to.window(self.selenium.window_handles[0]) self.selenium.switch_to.window(self.selenium.window_handles[0])
# Submit the new Traveler. # Submit the new Traveler.
self.selenium.find_element(By.CSS_SELECTOR, '[name="_save"]').click() with self.wait_page_loaded():
self.selenium.find_element(By.CSS_SELECTOR, '[name="_save"]').click()
traveler = Traveler.objects.get() traveler = Traveler.objects.get()
self.assertEqual(traveler.born_country.name, "Argentina") self.assertEqual(traveler.born_country.name, "Argentina")
self.assertEqual(traveler.living_country.name, "Italy") self.assertEqual(traveler.living_country.name, "Italy")