mirror of
https://github.com/django/django.git
synced 2025-06-05 11:39:13 +00:00
Fixed #36262 -- Made GeneratedField.db_persist a required key-word argument.
This commit is contained in:
parent
334677ad57
commit
9608678704
1
AUTHORS
1
AUTHORS
@ -479,6 +479,7 @@ answer newbie questions, and generally made Django that much better:
|
|||||||
Jarek Głowacki <jarekwg@gmail.com>
|
Jarek Głowacki <jarekwg@gmail.com>
|
||||||
Jarek Zgoda <jarek.zgoda@gmail.com>
|
Jarek Zgoda <jarek.zgoda@gmail.com>
|
||||||
Jarosław Wygoda <jaroslaw@wygoda.me>
|
Jarosław Wygoda <jaroslaw@wygoda.me>
|
||||||
|
Jason Cameron <https://jasoncameron.dev>
|
||||||
Jason Davies (Esaj) <https://www.jasondavies.com/>
|
Jason Davies (Esaj) <https://www.jasondavies.com/>
|
||||||
Jason Huggins <http://www.jrandolph.com/blog/>
|
Jason Huggins <http://www.jrandolph.com/blog/>
|
||||||
Jason McBrayer <http://www.carcosa.net/jason/>
|
Jason McBrayer <http://www.carcosa.net/jason/>
|
||||||
|
@ -15,7 +15,7 @@ class GeneratedField(Field):
|
|||||||
_query = None
|
_query = None
|
||||||
output_field = None
|
output_field = None
|
||||||
|
|
||||||
def __init__(self, *, expression, output_field, db_persist=None, **kwargs):
|
def __init__(self, *, expression, output_field, db_persist, **kwargs):
|
||||||
if kwargs.setdefault("editable", False):
|
if kwargs.setdefault("editable", False):
|
||||||
raise ValueError("GeneratedField cannot be editable.")
|
raise ValueError("GeneratedField cannot be editable.")
|
||||||
if not kwargs.setdefault("blank", True):
|
if not kwargs.setdefault("blank", True):
|
||||||
|
@ -1278,7 +1278,7 @@ when :attr:`~django.forms.Field.localize` is ``False`` or
|
|||||||
``GeneratedField``
|
``GeneratedField``
|
||||||
------------------
|
------------------
|
||||||
|
|
||||||
.. class:: GeneratedField(expression, output_field, db_persist=None, **kwargs)
|
.. class:: GeneratedField(*, expression, output_field, db_persist, **kwargs)
|
||||||
|
|
||||||
A field that is always computed based on other fields in the model. This field
|
A field that is always computed based on other fields in the model. This field
|
||||||
is managed and updated by the database itself. Uses the ``GENERATED ALWAYS``
|
is managed and updated by the database itself. Uses the ``GENERATED ALWAYS``
|
||||||
|
@ -94,11 +94,11 @@ class BaseGeneratedFieldTests(SimpleTestCase):
|
|||||||
)
|
)
|
||||||
|
|
||||||
def test_db_persist_required(self):
|
def test_db_persist_required(self):
|
||||||
msg = "GeneratedField.db_persist must be True or False."
|
with self.assertRaises(TypeError):
|
||||||
with self.assertRaisesMessage(ValueError, msg):
|
|
||||||
GeneratedField(
|
GeneratedField(
|
||||||
expression=Lower("name"), output_field=CharField(max_length=255)
|
expression=Lower("name"), output_field=CharField(max_length=255)
|
||||||
)
|
)
|
||||||
|
msg = "GeneratedField.db_persist must be True or False."
|
||||||
with self.assertRaisesMessage(ValueError, msg):
|
with self.assertRaisesMessage(ValueError, msg):
|
||||||
GeneratedField(
|
GeneratedField(
|
||||||
expression=Lower("name"),
|
expression=Lower("name"),
|
||||||
|
Loading…
x
Reference in New Issue
Block a user