mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-10-24 14:16:09 +00:00
Code Issues 32 Releases Wiki Activity

Refs #33543 -- Made Expression.asc()/desc() and OrderBy raise ValueError when nulls_first/nulls_last=False is passed.

Browse Source 
Per deprecation timeline.
This commit is contained in:
Mariusz Felisiak
2023-01-13 09:49:28 +01:00
parent 98756c685e
commit 94ad46e9d8
4 changed files with 10 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
tests/expressions/tests.py
View File

@@ -70,7 +70,6 @@ from django.test.utils import (
isolate_apps,
register_lookup,
)
from django.utils.deprecation import RemovedInDjango50Warning
from django.utils.functional import SimpleLazyObject
from .models import (
@@ -2632,18 +2631,12 @@ class OrderByTests(SimpleTestCase):
)
def test_nulls_false(self):
# These tests will catch ValueError in Django 5.0 when passing False to
# nulls_first and nulls_last becomes forbidden.
# msg = "nulls_first and nulls_last values must be True or None."
msg = (
"Passing nulls_first=False or nulls_last=False is deprecated, use None "
"instead."
)
with self.assertRaisesMessage(RemovedInDjango50Warning, msg):
msg = "nulls_first and nulls_last values must be True or None."
with self.assertRaisesMessage(ValueError, msg):
OrderBy(F("field"), nulls_first=False)
with self.assertRaisesMessage(RemovedInDjango50Warning, msg):
with self.assertRaisesMessage(ValueError, msg):
OrderBy(F("field"), nulls_last=False)
with self.assertRaisesMessage(RemovedInDjango50Warning, msg):
with self.assertRaisesMessage(ValueError, msg):
F("field").asc(nulls_first=False)
with self.assertRaisesMessage(RemovedInDjango50Warning, msg):
with self.assertRaisesMessage(ValueError, msg):
F("field").desc(nulls_last=False)