mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-10-26 15:16:09 +00:00
Code Issues 32 Releases Wiki Activity

[1.5.x] Avoided a possible regression in 5097d3c5.

Browse Source 
QuerySet.none() returns an instance of EmptyQuerySet, which may have
undesirable side effects in the presence of custom query set classes.

The implementation of .none() was refactored in master to have the same
effect as .filter(pk__in=[]).

Refs #19652.

Thanks Simon Charrette for the report.
This commit is contained in:
Aymeric Augustin
2013-01-24 11:12:48 +01:00
parent 1c061ef568
commit 9328ef0e84
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
django/forms/models.py
View File

@@ -715,7 +715,7 @@ class BaseInlineFormSet(BaseModelFormSet):
if self.instance.pk: if self.instance.pk:
qs = queryset.filter(**{self.fk.name: self.instance}) qs = queryset.filter(**{self.fk.name: self.instance})
else: else:
qs = queryset.none() qs = queryset.filter(pk__in=[])
super(BaseInlineFormSet, self).__init__(data, files, prefix=prefix, super(BaseInlineFormSet, self).__init__(data, files, prefix=prefix,
queryset=qs, **kwargs) queryset=qs, **kwargs)