mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-10-24 06:06:09 +00:00
Code Issues 32 Releases Wiki Activity

Refs #30446, Refs #34944 -- Fixed crash when adding GeneratedField with string Value().

Browse Source 
This should allow smarter output_field inferring in functions dealing
with text expressions.

Regression in f333e3513e.
This commit is contained in:
Simon Charette
2023-11-07 21:47:37 -05:00
committed by Mariusz Felisiak
parent 5f2f12f61c
commit 8b1acc0440
3 changed files with 19 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
tests/schema/tests.py
View File

@@ -842,6 +842,23 @@ class SchemaTests(TransactionTestCase):
False,
)
@isolate_apps("schema")
@skipUnlessDBFeature("supports_stored_generated_columns")
def test_add_generated_field_with_string_value(self):
class GeneratedFieldStringValueModel(Model):
value = GeneratedField(expression=Value("static string"), db_persist=True)
class Meta:
app_label = "schema"
with CaptureQueriesContext(connection) as ctx:
with connection.schema_editor() as editor:
editor.create_model(GeneratedFieldStringValueModel)
self.assertIs(
any("None" in query["sql"] for query in ctx.captured_queries),
False,
)
@isolate_apps("schema")
@skipUnlessDBFeature("supports_stored_generated_columns")
def test_add_generated_field_with_output_field(self):