From 89920e058fcb673ff82ae67a41566216895c8bd3 Mon Sep 17 00:00:00 2001
From: Malcolm Tredinnick <malcolm.tredinnick@gmail.com>
Date: Thu, 8 Jun 2006 00:13:52 +0000
Subject: [PATCH] Fixed #2108 -- do not try to save an empty model.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@3104 bcc190cf-cafb-0310-a4f2-bffc1f526a37
---
 django/db/models/base.py           | 11 ++++++-----
 tests/modeltests/empty/__init__.py |  0
 tests/modeltests/empty/models.py   | 17 +++++++++++++++++
 3 files changed, 23 insertions(+), 5 deletions(-)
 create mode 100644 tests/modeltests/empty/__init__.py
 create mode 100644 tests/modeltests/empty/models.py

diff --git a/django/db/models/base.py b/django/db/models/base.py
index 3538826356..68e805e003 100644
--- a/django/db/models/base.py
+++ b/django/db/models/base.py
@@ -183,11 +183,12 @@ class Model(object):
                 placeholders.append('(SELECT COUNT(*) FROM %s WHERE %s = %%s)' % \
                     (backend.quote_name(self._meta.db_table), backend.quote_name(self._meta.order_with_respect_to.column)))
                 db_values.append(getattr(self, self._meta.order_with_respect_to.attname))
-            cursor.execute("INSERT INTO %s (%s) VALUES (%s)" % \
-                (backend.quote_name(self._meta.db_table), ','.join(field_names),
-                ','.join(placeholders)), db_values)
-            if self._meta.has_auto_field and not pk_set:
-                setattr(self, self._meta.pk.attname, backend.get_last_insert_id(cursor, self._meta.db_table, self._meta.pk.column))
+            if db_values:
+                cursor.execute("INSERT INTO %s (%s) VALUES (%s)" % \
+                    (backend.quote_name(self._meta.db_table), ','.join(field_names),
+                    ','.join(placeholders)), db_values)
+                if self._meta.has_auto_field and not pk_set:
+                    setattr(self, self._meta.pk.attname, backend.get_last_insert_id(cursor, self._meta.db_table, self._meta.pk.column))
         transaction.commit_unless_managed()
 
         # Run any post-save hooks.
diff --git a/tests/modeltests/empty/__init__.py b/tests/modeltests/empty/__init__.py
new file mode 100644
index 0000000000..e69de29bb2
diff --git a/tests/modeltests/empty/models.py b/tests/modeltests/empty/models.py
new file mode 100644
index 0000000000..2d0c42983b
--- /dev/null
+++ b/tests/modeltests/empty/models.py
@@ -0,0 +1,17 @@
+"""
+Empty model tests
+
+These test that things behave sensibly for the rare corner-case of a model with
+no fields.
+"""
+
+from django.db import models
+
+class Empty(models.Model):
+    pass
+
+API_TESTS = """
+>>> m = Empty()
+>>> m.save()
+
+"""