mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-01-03 06:55:47 +00:00
Code Issues 30 Releases Wiki Activity

Fixed #35546 -- Emphasised accepted ticket requirement in contributing docs.

Browse Source
This commit is contained in:
Maryam Yusuf 2024-07-27 10:48:34 +02:00 committed by Sarah Boyce
parent 9d10c7ab33
commit 7e00fee3bd
2 changed files with 14 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
docs/internals/contributing/bugs-and-features.txt
View File

@ -110,11 +110,6 @@ part of that. Here are some tips on how to make a request most effectively:
If there's a consensus agreement on the feature, then it's appropriate to If there's a consensus agreement on the feature, then it's appropriate to
create a ticket. Include a link to the discussion in the ticket description. create a ticket. Include a link to the discussion in the ticket description.
As with most open-source projects, code talks. If you are willing to write the
code for the feature yourself or, even better, if you've already written it,
it's much more likely to be accepted. Fork Django on GitHub, create a feature
branch, and show us your work!
See also: :ref:`documenting-new-features`. See also: :ref:`documenting-new-features`.
Requesting performance optimizations Requesting performance optimizations

20
docs/internals/contributing/writing-code/submitting-patches.txt
View File

@ -6,6 +6,8 @@ We're always grateful for contributions to Django's code. Indeed, bug reports
with associated contributions will get fixed *far* more quickly than those with associated contributions will get fixed *far* more quickly than those
without a solution. without a solution.
.. _trivial-change:
Typo fixes and trivial documentation changes Typo fixes and trivial documentation changes
============================================ ============================================
@ -52,9 +54,10 @@ and time availability), claim it by following these steps:
.. note:: .. note::
The Django software foundation requests that anyone contributing more than The Django software foundation requests that anyone contributing more than
a trivial change to Django sign and submit a `Contributor License a :ref:`trivial change <trivial-change>`, to Django sign and submit a
Agreement`_, this ensures that the Django Software Foundation has clear `Contributor License Agreement`_, this ensures that the Django Software
license to all contributions allowing for a clear license for all users. Foundation has clear license to all contributions allowing for a clear
license for all users.
.. _Login using your GitHub account: https://code.djangoproject.com/github/login .. _Login using your GitHub account: https://code.djangoproject.com/github/login
.. _Create an account: https://www.djangoproject.com/accounts/register/ .. _Create an account: https://www.djangoproject.com/accounts/register/
@ -280,9 +283,12 @@ benchmarks can be run on a pull request by labeling the pull request with
Contribution checklist Contribution checklist
====================== ======================
Use this checklist to review a pull request. If you are reviewing a pull Use this checklist to review a pull request. If this contribution would not be
request that is not your own and it passes all the criteria below, please set :ref:`considered trivial <trivial-change>`, first ensure it has an accepted
the "Triage Stage" on the corresponding Trac ticket to "Ready for checkin". ticket before proceeding with the review.
If the pull request passes all the criteria below and is not your own, please
set the "Triage Stage" on the corresponding Trac ticket to "Ready for checkin".
If you've left comments for improvement on the pull request, please tick the If you've left comments for improvement on the pull request, please tick the
appropriate flags on the Trac ticket based on the results of your review: appropriate flags on the Trac ticket based on the results of your review:
"Patch needs improvement", "Needs documentation", and/or "Needs tests". As time "Patch needs improvement", "Needs documentation", and/or "Needs tests". As time
@ -352,5 +358,7 @@ All tickets
:ref:`commit message format <committing-guidelines>`? :ref:`commit message format <committing-guidelines>`?
* Are you the patch author and a new contributor? Please add yourself to the * Are you the patch author and a new contributor? Please add yourself to the
:source:`AUTHORS` file and submit a `Contributor License Agreement`_. :source:`AUTHORS` file and submit a `Contributor License Agreement`_.
* Does this have an accepted ticket on Trac? All contributions require a ticket
unless the :ref:`change is considered trivial <trivial-change>`.
.. _Contributor License Agreement: https://www.djangoproject.com/foundation/cla/ .. _Contributor License Agreement: https://www.djangoproject.com/foundation/cla/