From 78da5ca0c1f2ab3201f8f6cd629e80d805ea023d Mon Sep 17 00:00:00 2001 From: Mariusz Felisiak Date: Wed, 15 Mar 2023 13:05:48 +0100 Subject: [PATCH] Reverted "Fixed #33213 -- Doc'd testing code coverage in parallel and used it." This reverts commit 69352d85fa8412865db9e0c7f177b333c0eac3e2. Test coverage for async methods was no longer calculated with this change. --- .gitignore | 2 +- .../contributing/writing-code/unit-tests.txt | 13 ++++--------- tests/.coveragerc | 2 -- 3 files changed, 5 insertions(+), 12 deletions(-) diff --git a/.gitignore b/.gitignore index 6a67c6eb28..238fb3a200 100644 --- a/.gitignore +++ b/.gitignore @@ -13,6 +13,6 @@ docs/_build/ docs/locale/ node_modules/ tests/coverage_html/ -tests/.coverage* +tests/.coverage build/ tests/report/ diff --git a/docs/internals/contributing/writing-code/unit-tests.txt b/docs/internals/contributing/writing-code/unit-tests.txt index 40fb2ec221..634611dcfb 100644 --- a/docs/internals/contributing/writing-code/unit-tests.txt +++ b/docs/internals/contributing/writing-code/unit-tests.txt @@ -357,19 +357,14 @@ Contributors are encouraged to run coverage on the test suite to identify areas that need additional tests. The coverage tool installation and use is described in :ref:`testing code coverage`. -To run coverage on the Django test suite using the standard test settings: +Coverage should be run in a single process to obtain accurate statistics. To +run coverage on the Django test suite using the standard test settings: .. console:: - $ coverage run ./runtests.py --settings=test_sqlite + $ coverage run ./runtests.py --settings=test_sqlite --parallel=1 -After running coverage, combine all coverage statistics by running: - -.. console:: - - $ coverage combine - -After that generate the html report by running: +After running coverage, generate the html report by running: .. console:: diff --git a/tests/.coveragerc b/tests/.coveragerc index 258c82e8ee..e519f06259 100644 --- a/tests/.coveragerc +++ b/tests/.coveragerc @@ -1,7 +1,5 @@ [run] branch = True -concurrency = multiprocessing -data_file = .coverages/.coverage omit = */django/utils/autoreload.py source = django