1
0
mirror of https://github.com/django/django.git synced 2025-10-23 21:59:11 +00:00

Fixed #24366 -- Optimized traversal of large migration dependency graphs.

Switched from an adjancency list and uncached, iterative depth-first
search to a Node-based design with direct parent/child links and a
cached, recursive depth-first search. With this change, calculating
a migration plan for a large graph takes several seconds instead of
several hours.

Marked test `migrations.test_graph.GraphTests.test_dfs` as an expected
failure due to reaching the maximum recursion depth.
This commit is contained in:
Marten Kenbeek
2015-02-20 05:43:45 +01:00
committed by Markus Holtermann
parent 7fa7dd48c4
commit 78d43a5e10
3 changed files with 112 additions and 33 deletions

View File

@@ -1,3 +1,5 @@
from unittest import expectedFailure
from django.db.migrations.graph import (
CircularDependencyError, MigrationGraph, NodeNotFoundError,
)
@@ -151,7 +153,23 @@ class GraphTests(TestCase):
graph.forwards_plan, ('C', '0001')
)
def test_dfs(self):
def test_deep_graph(self):
graph = MigrationGraph()
root = ("app_a", "1")
graph.add_node(root, None)
expected = [root]
for i in range(2, 750):
parent = ("app_a", str(i - 1))
child = ("app_a", str(i))
graph.add_node(child, None)
graph.add_dependency(str(i), child, parent)
expected.append(child)
actual = graph.node_map[root].descendants()
self.assertEqual(expected[::-1], actual)
@expectedFailure
def test_recursion_depth(self):
graph = MigrationGraph()
root = ("app_a", "1")
graph.add_node(root, None)
@@ -163,7 +181,7 @@ class GraphTests(TestCase):
graph.add_dependency(str(i), child, parent)
expected.append(child)
actual = graph.dfs(root, lambda x: graph.dependents.get(x, set()))
actual = graph.node_map[root].descendants()
self.assertEqual(expected[::-1], actual)
def test_plan_invalid_node(self):