mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-10-24 06:06:09 +00:00
Code Issues 32 Releases Wiki Activity

Refs #24366 -- Fixed recursion depth error in migration graph

Browse Source 
Made MigrationGraph forwards_plan() and backwards_plan() fall back to an
iterative approach in case the recursive approach exceeds the recursion
depth limit.
This commit is contained in:
Marten Kenbeek
2015-03-28 17:46:10 +01:00
committed by Markus Holtermann
parent bc83add04c
commit 75430be86f
2 changed files with 68 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
tests/migrations/test_graph.py
View File

@@ -1,7 +1,8 @@
from unittest import expectedFailure
import warnings
from django.db.migrations.graph import (
CircularDependencyError, MigrationGraph, NodeNotFoundError,
RECURSION_DEPTH_WARNING, CircularDependencyError, MigrationGraph,
NodeNotFoundError,
)
from django.test import TestCase
from django.utils.encoding import force_text
@@ -164,11 +165,14 @@ class GraphTests(TestCase):
graph.add_node(child, None)
graph.add_dependency(str(i), child, parent)
expected.append(child)
leaf = expected[-1]
actual = graph.node_map[root].descendants()
self.assertEqual(expected[::-1], actual)
forwards_plan = graph.forwards_plan(leaf)
self.assertEqual(expected, forwards_plan)
backwards_plan = graph.backwards_plan(root)
self.assertEqual(expected[::-1], backwards_plan)
@expectedFailure
def test_graph_iterative(self):
graph = MigrationGraph()
root = ("app_a", "1")
@@ -180,9 +184,23 @@ class GraphTests(TestCase):
graph.add_node(child, None)
graph.add_dependency(str(i), child, parent)
expected.append(child)
leaf = expected[-1]
actual = graph.node_map[root].descendants()
self.assertEqual(expected[::-1], actual)
with warnings.catch_warnings(record=True) as w:
forwards_plan = graph.forwards_plan(leaf)
self.assertEqual(len(w), 1)
self.assertTrue(issubclass(w[-1].category, RuntimeWarning))
self.assertEqual(str(w[-1].message), RECURSION_DEPTH_WARNING)
self.assertEqual(expected, forwards_plan)
with warnings.catch_warnings(record=True) as w:
backwards_plan = graph.backwards_plan(root)
self.assertEqual(len(w), 1)
self.assertTrue(issubclass(w[-1].category, RuntimeWarning))
self.assertEqual(str(w[-1].message), RECURSION_DEPTH_WARNING)
self.assertEqual(expected[::-1], backwards_plan)
def test_plan_invalid_node(self):
"""