From 7405446b2e7ab27a40d768edbc928f66f9da5652 Mon Sep 17 00:00:00 2001 From: Russell Keith-Magee Date: Fri, 31 Aug 2007 05:43:21 +0000 Subject: [PATCH] newforms-admin: Made import visibility of formsets and Media consistent with that of fields, widgets and forms. git-svn-id: http://code.djangoproject.com/svn/django/branches/newforms-admin@6029 bcc190cf-cafb-0310-a4f2-bffc1f526a37 --- django/contrib/admin/options.py | 12 +++++------- django/newforms/__init__.py | 1 + django/newforms/formsets.py | 2 ++ django/newforms/models.py | 2 +- django/newforms/widgets.py | 2 +- 5 files changed, 10 insertions(+), 9 deletions(-) diff --git a/django/contrib/admin/options.py b/django/contrib/admin/options.py index 356de2e72c..9071c18717 100644 --- a/django/contrib/admin/options.py +++ b/django/contrib/admin/options.py @@ -1,8 +1,6 @@ from django import oldforms, template from django import newforms as forms from django.newforms.formsets import all_valid -from django.newforms.models import inline_formset -from django.newforms.widgets import Media, MediaDefiningClass from django.contrib.admin import widgets from django.contrib.admin.util import get_deleted_objects from django.core.exceptions import ImproperlyConfigured, PermissionDenied @@ -67,8 +65,8 @@ class Fieldset(object): def _media(self): from django.conf import settings if 'collapse' in self.classes: - return Media(js=['%sjs/admin/CollapsedFieldsets.js' % settings.ADMIN_MEDIA_PREFIX]) - return Media() + return forms.Media(js=['%sjs/admin/CollapsedFieldsets.js' % settings.ADMIN_MEDIA_PREFIX]) + return forms.Media() media = property(_media) class BoundFieldset(object): @@ -165,7 +163,7 @@ class BaseModelAdmin(object): class ModelAdmin(BaseModelAdmin): "Encapsulates all admin options and functionality for a given model." - __metaclass__ = MediaDefiningClass + __metaclass__ = forms.MediaDefiningClass list_display = ('__str__',) list_display_links = () @@ -220,7 +218,7 @@ class ModelAdmin(BaseModelAdmin): if self.filter_vertical or self.filter_horizontal: js.extend(['js/SelectBox.js' , 'js/SelectFilter2.js']) - return Media(js=['%s%s' % (settings.ADMIN_MEDIA_PREFIX, url) for url in js]) + return forms.Media(js=['%s%s' % (settings.ADMIN_MEDIA_PREFIX, url) for url in js]) media = property(_media) def fieldsets(self, request): @@ -613,7 +611,7 @@ class ModelAdmin(BaseModelAdmin): def get_inline_formsets(self): inline_formset_classes = [] for opts in self.inlines: - inline = inline_formset(self.model, opts.model, formfield_callback=opts.formfield_for_dbfield, fields=opts.fields, extra=opts.extra) + inline = forms.inline_formset(self.model, opts.model, formfield_callback=opts.formfield_for_dbfield, fields=opts.fields, extra=opts.extra) inline_formset_classes.append(inline) return inline_formset_classes diff --git a/django/newforms/__init__.py b/django/newforms/__init__.py index 0d9c68f9e0..99631e4e8f 100644 --- a/django/newforms/__init__.py +++ b/django/newforms/__init__.py @@ -15,3 +15,4 @@ from widgets import * from fields import * from forms import * from models import * +from formsets import * \ No newline at end of file diff --git a/django/newforms/formsets.py b/django/newforms/formsets.py index 38982b47de..ef1083ba28 100644 --- a/django/newforms/formsets.py +++ b/django/newforms/formsets.py @@ -2,6 +2,8 @@ from forms import Form, ValidationError from fields import IntegerField, BooleanField from widgets import HiddenInput, Media +__all__ = ('BaseFormSet', 'formset_for_form', 'all_valid') + # special field names FORM_COUNT_FIELD_NAME = 'COUNT' ORDERING_FIELD_NAME = 'ORDER' diff --git a/django/newforms/models.py b/django/newforms/models.py index 16800dfdbf..6b674bd757 100644 --- a/django/newforms/models.py +++ b/django/newforms/models.py @@ -15,7 +15,7 @@ from widgets import Select, SelectMultiple, HiddenInput, MultipleHiddenInput __all__ = ( 'save_instance', 'form_for_model', 'form_for_instance', 'form_for_fields', - 'ModelChoiceField', 'ModelMultipleChoiceField' + 'ModelChoiceField', 'ModelMultipleChoiceField', 'inline_formset' ) def save_instance(form, instance, fields=None, fail_message='saved', commit=True): diff --git a/django/newforms/widgets.py b/django/newforms/widgets.py index 2f157ade75..8aa375abf0 100644 --- a/django/newforms/widgets.py +++ b/django/newforms/widgets.py @@ -17,7 +17,7 @@ from util import flatatt from urlparse import urljoin __all__ = ( - 'Media', 'Widget', 'TextInput', 'PasswordInput', + 'Media', 'MediaDefiningClass', 'Widget', 'TextInput', 'PasswordInput', 'HiddenInput', 'MultipleHiddenInput', 'FileInput', 'Textarea', 'CheckboxInput', 'Select', 'NullBooleanSelect', 'SelectMultiple', 'RadioSelect',