From 72ff18d41cfb004ae180bdf87fd8bad93041c691 Mon Sep 17 00:00:00 2001 From: Jacob Walls Date: Wed, 22 Jan 2025 22:21:09 -0500 Subject: [PATCH] Fixed #36120 -- Raised FieldError when targeting a composite primary key field with QuerySet.update(). --- django/db/models/sql/subqueries.py | 4 ++++ tests/composite_pk/test_update.py | 7 +++++++ 2 files changed, 11 insertions(+) diff --git a/django/db/models/sql/subqueries.py b/django/db/models/sql/subqueries.py index b2810c8413..9cb971b38f 100644 --- a/django/db/models/sql/subqueries.py +++ b/django/db/models/sql/subqueries.py @@ -90,6 +90,10 @@ class UpdateQuery(Query): not (field.auto_created and not field.concrete) or not field.concrete ) model = field.model._meta.concrete_model + if field.name == "pk" and model._meta.is_composite_pk: + raise FieldError( + "Composite primary key fields must be updated individually." + ) if not direct or (field.is_relation and field.many_to_many): raise FieldError( "Cannot update model field %r (only non-relations and " diff --git a/tests/composite_pk/test_update.py b/tests/composite_pk/test_update.py index ec770230fc..5bc53f1fe1 100644 --- a/tests/composite_pk/test_update.py +++ b/tests/composite_pk/test_update.py @@ -1,3 +1,4 @@ +from django.core.exceptions import FieldError from django.db import connection from django.test import TestCase @@ -175,3 +176,9 @@ class CompositePKUpdateTests(TestCase): with self.assertRaisesMessage(ValueError, msg): Comment.objects.update(user=User()) + + def test_cant_update_pk_field(self): + qs = Comment.objects.filter(user__email=self.user_1.email) + msg = "Composite primary key fields must be updated individually." + with self.assertRaisesMessage(FieldError, msg): + qs.update(pk=(1, 10))