mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-10-31 09:41:08 +00:00
Code Issues 32 Releases Wiki Activity

Fixed #31723 -- Fixed window functions crash with DecimalField on SQLite.

Browse Source 
Thanks Simon Charette for the initial patch.
This commit is contained in:
Hasan Ramezani
2020-09-22 15:01:52 +02:00
committed by Mariusz Felisiak
parent 2a55431a56
commit 71d10ca8c9
3 changed files with 42 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
django/db/models/expressions.py
View File

@@ -1253,7 +1253,7 @@ class OrderBy(BaseExpression):
self.descending = True
class Window(Expression):
class Window(SQLiteNumericMixin, Expression):
template = '%(expression)s OVER (%(window)s)'
# Although the main expression may either be an aggregate or an
# expression with an aggregate function, the GROUP BY that will
@@ -1332,6 +1332,16 @@ class Window(Expression):
'window': ''.join(window_sql).strip()
}, params
def as_sqlite(self, compiler, connection):
if isinstance(self.output_field, fields.DecimalField):
# Casting to numeric must be outside of the window expression.
copy = self.copy()
source_expressions = copy.get_source_expressions()
source_expressions[0].output_field = fields.FloatField()
copy.set_source_expressions(source_expressions)
return super(Window, copy).as_sqlite(compiler, connection)
return self.as_sql(compiler, connection)
def __str__(self):
return '{} OVER ({}{}{})'.format(
str(self.source_expression),