mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-11-07 07:15:35 +00:00
Code Issues 32 Releases Wiki Activity

Fixed IntegrityError in bulk_create.tests.BulkCreateTransactionTests due to duplicate primary keys.

Browse Source 
Some tests in BulkCreateTransactionTests were inserting Country objects
with hardcoded primary keys, which could conflict with existing rows
(if the sequence value wasn't bumped by another test).

Updated the tests to dynamically select an unused primary key instead.

Thanks to Simon Charette for the exhaustive and enlightening review.
This commit is contained in:
Natalia
2025-10-24 09:50:01 -03:00
committed by nessita
parent 7423918125
commit 6fcbbe0b85
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tests/bulk_create/tests.py
View File

@@ -889,19 +889,27 @@ class BulkCreateTests(TestCase):
class BulkCreateTransactionTests(TransactionTestCase):
available_apps = ["bulk_create"]
def get_unused_country_id(self):
# Find a serial ID that hasn't been used already and has enough of a
# buffer for the following `bulk_create` call without an explicit pk
# not to conflict.
return getattr(Country.objects.last(), "id", 10) + 100
def test_no_unnecessary_transaction(self):
unused_id = self.get_unused_country_id()
with self.assertNumQueries(1):
Country.objects.bulk_create(
[Country(id=1, name="France", iso_two_letter="FR")]
[Country(id=unused_id, name="France", iso_two_letter="FR")]
)
with self.assertNumQueries(1):
Country.objects.bulk_create([Country(name="Canada", iso_two_letter="CA")])
def test_objs_with_and_without_pk(self):
unused_id = self.get_unused_country_id()
with self.assertNumQueries(4):
Country.objects.bulk_create(
[
Country(id=10, name="France", iso_two_letter="FR"),
Country(id=unused_id, name="France", iso_two_letter="FR"),
Country(name="Canada", iso_two_letter="CA"),
]
)