mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-06-17 01:19:12 +00:00
Code Issues 32 Releases Wiki Activity

magic-removal: Removed _pre_save(), _post_save(), _pre_delete() and _post_delete() hooks. Just subclass the save() and delete() methods now.

Browse Source 
git-svn-id: http://code.djangoproject.com/svn/django/branches/magic-removal@2038 bcc190cf-cafb-0310-a4f2-bffc1f526a37
This commit is contained in:
Adrian Holovaty 2006-01-17 19:27:27 +00:00
parent 51d2de6a56
commit 6e8d06572a
2 changed files with 1 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
django/db/models/base.py
View File

@ -137,9 +137,6 @@ class Model(object):
_prepare = classmethod(_prepare) _prepare = classmethod(_prepare)
def save(self): def save(self):
# Run any pre-save hooks.
if hasattr(self, '_pre_save'):
self._pre_save()
dispatcher.send(signal=signals.pre_save, sender=self.__class__, instance=self) dispatcher.send(signal=signals.pre_save, sender=self.__class__, instance=self)
non_pks = [f for f in self._meta.fields if not f.primary_key] non_pks = [f for f in self._meta.fields if not f.primary_key]
@ -187,9 +184,6 @@ class Model(object):
# Run any post-save hooks. # Run any post-save hooks.
dispatcher.send(signal=signals.pre_save, sender=self.__class__, instance=self) dispatcher.send(signal=signals.pre_save, sender=self.__class__, instance=self)
if hasattr(self, '_post_save'):
self._post_save()
save.alters_data = True save.alters_data = True
def __get_pk_val(self): def __get_pk_val(self):
@ -240,9 +234,6 @@ class Model(object):
# Run any pre-delete hooks. # Run any pre-delete hooks.
if do_delete: if do_delete:
if hasattr(instance, '_pre_delete'):
instance._pre_delete()
dispatcher.send(signal=signals.pre_delete, sender=cls, instance=instance) dispatcher.send(signal=signals.pre_delete, sender=cls, instance=instance)
for related in cls._meta.get_all_related_many_to_many_objects(): for related in cls._meta.get_all_related_many_to_many_objects():
@ -276,9 +267,6 @@ class Model(object):
dispatcher.send(signal=signals.post_delete, sender=cls, instance=instance) dispatcher.send(signal=signals.post_delete, sender=cls, instance=instance)
if hasattr(instance, '_post_delete'):
instance._post_delete()
connection.commit() connection.commit()
delete.alters_data = True delete.alters_data = True

19
docs/model-api.txt
View File

@ -1022,25 +1022,6 @@ A few object methods have special meaning:
It's good practice to use ``get_absolute_url()`` in templates, instead of It's good practice to use ``get_absolute_url()`` in templates, instead of
hard-coding your objects' URLs. hard-coding your objects' URLs.
``_pre_save``
This method is called just before an object is saved to the database. For
example, you can use it to calculate aggregate values from other fields
before the object is saved.
See `Adding hooks before/after saving and deleting`_ for a full example.
.. _Adding hooks before/after saving and deleting: http://www.djangoproject.com/documentation/models/save_delete_hooks/
``_post_save``
This method is called just after the object is saved to the database. This
could be used to update other tables, update cached information, etc.
``_pre_delete``
Like ``_pre_save``, but for deletion.
``_post_delete``
Like ``_post_save``, but for deletion.
Module-level methods Module-level methods
-------------------- --------------------