Removed superfluous models.py files.

Added comments in the three empty models.py files that are still needed. Adjusted the test runner to add applications corresponding to test labels to INSTALLED_APPS even when they don't have a models module.
2024-12-22 09:05:43 +00:00 · 2013-12-17 10:27:08 +01:00 · 2013-12-17 10:27:08 +01:00 · 6e895f9e06
commit 6e895f9e06
parent 4a56a93cc4
50 changed files with 9 additions and 16 deletions
--- a/django/contrib/admindocs/models.py
+++ b/django/contrib/admindocs/models.py
@ -1 +0,0 @@
-# Empty models.py to allow for specifying admindocs as a test label.
--- a/django/contrib/formtools/models.py
+++ b/django/contrib/formtools/models.py
@ -1 +1,2 @@
-""" models.py (even empty) currently required by the runtests.py to enable unit tests """
+# This file is required to pretend formtools has models.
+# Otherwise test models cannot be registered.
--- a/django/contrib/humanize/models.py
+++ b/django/contrib/humanize/models.py
--- a/django/contrib/messages/models.py
+++ b/django/contrib/messages/models.py
@ -1 +0,0 @@
-# Models module required so tests are discovered.
--- a/django/contrib/sitemaps/models.py
+++ b/django/contrib/sitemaps/models.py
@ -1 +1,2 @@
-# This file intentionally left blank
+# This file is required to pretend sitemaps has models.
+# Otherwise test models cannot be registered.
--- a/django/contrib/staticfiles/models.py
+++ b/django/contrib/staticfiles/models.py
--- a/django/contrib/webdesign/models.py
+++ b/django/contrib/webdesign/models.py
--- a/tests/admin_docs/models.py
+++ b/tests/admin_docs/models.py
--- a/tests/admin_scripts/custom_templates/app_template/models.py
+++ b/tests/admin_scripts/custom_templates/app_template/models.py
@ -1 +0,0 @@
-# whatever
--- a/tests/app_loading/models.py
+++ b/tests/app_loading/models.py
--- a/tests/bash_completion/models.py
+++ b/tests/bash_completion/models.py
--- a/tests/builtin_server/models.py
+++ b/tests/builtin_server/models.py
--- a/tests/conditional_processing/models.py
+++ b/tests/conditional_processing/models.py
--- a/tests/context_processors/models.py
+++ b/tests/context_processors/models.py
@ -1 +0,0 @@
-# Models file for tests to run.
--- a/tests/createsuperuser/models.py
+++ b/tests/createsuperuser/models.py
--- a/tests/csrf_tests/models.py
+++ b/tests/csrf_tests/models.py
@ -1 +0,0 @@
-# models.py file for tests to run.
--- a/tests/db_typecasts/models.py
+++ b/tests/db_typecasts/models.py
--- a/tests/decorators/models.py
+++ b/tests/decorators/models.py
@ -1 +0,0 @@
-# A models.py so that tests run.
--- a/tests/defaultfilters/models.py
+++ b/tests/defaultfilters/models.py
--- a/tests/deprecation/models.py
+++ b/tests/deprecation/models.py
--- a/tests/dispatch/models.py
+++ b/tests/dispatch/models.py
--- a/tests/field_deconstruction/models.py
+++ b/tests/field_deconstruction/models.py
--- a/tests/files/models.py
+++ b/tests/files/models.py
--- a/tests/handlers/models.py
+++ b/tests/handlers/models.py
--- a/tests/http_utils/models.py
+++ b/tests/http_utils/models.py
--- a/tests/httpwrappers/models.py
+++ b/tests/httpwrappers/models.py
--- a/tests/i18n/resolution/models.py
+++ b/tests/i18n/resolution/models.py
@ -1 +0,0 @@
-#
--- a/tests/invalid_models/models.py
+++ b/tests/invalid_models/models.py
--- a/tests/logging_tests/models.py
+++ b/tests/logging_tests/models.py
--- a/tests/middleware_exceptions/models.py
+++ b/tests/middleware_exceptions/models.py
--- a/tests/migrate_signals/models.py
+++ b/tests/migrate_signals/models.py
@ -0,0 +1,2 @@
+# Remove this module when pre/post_migrate are refactored to use something
+# other than a models module for their "sender" argument.
--- a/tests/migrations/migrations_test_apps/normal/models.py
+++ b/tests/migrations/migrations_test_apps/normal/models.py
--- a/tests/requests/models.py
+++ b/tests/requests/models.py
@ -1 +0,0 @@
-# Need a models module for the test runner.
--- a/tests/responses/models.py
+++ b/tests/responses/models.py
--- a/tests/runtests.py
+++ b/tests/runtests.py
@ -164,10 +164,9 @@ def setup(verbosity, test_labels):
        if module_found_in_labels:
            if verbosity >= 2:
                print("Importing application %s" % module_name)
-            mod = app_cache.load_app(module_label)
-            if mod:
-                if module_label not in settings.INSTALLED_APPS:
-                    settings.INSTALLED_APPS.append(module_label)
+            app_cache.load_app(module_label)
+            if module_label not in settings.INSTALLED_APPS:
+                settings.INSTALLED_APPS.append(module_label)

    return state

--- a/tests/servers/another_app/models.py
+++ b/tests/servers/another_app/models.py
--- a/tests/signed_cookies_tests/models.py
+++ b/tests/signed_cookies_tests/models.py
@ -1 +0,0 @@
-# models.py file for tests to run.
--- a/tests/signing/models.py
+++ b/tests/signing/models.py
@ -1 +0,0 @@
-# models.py file for tests to run.
--- a/tests/staticfiles_tests/apps/no_label/models.py
+++ b/tests/staticfiles_tests/apps/no_label/models.py
--- a/tests/staticfiles_tests/apps/test/models.py
+++ b/tests/staticfiles_tests/apps/test/models.py
--- a/tests/staticfiles_tests/models.py
+++ b/tests/staticfiles_tests/models.py
--- a/tests/template_tests/models.py
+++ b/tests/template_tests/models.py
--- a/tests/test_client/models.py
+++ b/tests/test_client/models.py
--- a/tests/test_runner_deprecation_app/models.py
+++ b/tests/test_runner_deprecation_app/models.py
--- a/tests/test_suite_override/models.py
+++ b/tests/test_suite_override/models.py
--- a/tests/text/models.py
+++ b/tests/text/models.py
--- a/tests/urlpatterns_reverse/models.py
+++ b/tests/urlpatterns_reverse/models.py
--- a/tests/validators/models.py
+++ b/tests/validators/models.py
--- a/tests/version/models.py
+++ b/tests/version/models.py
--- a/tests/wsgi/models.py
+++ b/tests/wsgi/models.py
				`@ -1 +0,0 @@`
				`# Empty models.py to allow for specifying admindocs as a test label.`
				`@ -1 +0,0 @@`
				`# Models module required so tests are discovered.`