mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-10-31 09:41:08 +00:00
Code Issues 32 Releases Wiki Activity

[4.2.x] Fixed #35006 -- Fixed migrations crash when altering Meta.db_table_comment on SQLite.

Browse Source 
Thanks Юрий for the report.

Regression in 78f163a4fb.
Backport of 37fc832a54 from main
This commit is contained in:
Mariusz Felisiak
2023-11-30 10:10:27 +01:00
parent 5b698cbcf1
commit 6e2d9f0aa8
4 changed files with 30 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
tests/schema/tests.py
View File

@@ -4727,6 +4727,23 @@ class SchemaTests(TransactionTestCase):
[None, ""],
)
@isolate_apps("schema")
@skipIfDBFeature("supports_comments")
def test_db_comment_table_unsupported(self):
class ModelWithDbTableComment(Model):
class Meta:
app_label = "schema"
db_table_comment = "Custom table comment"
# Table comments are ignored on databases that don't support them.
with connection.schema_editor() as editor, self.assertNumQueries(1):
editor.create_model(ModelWithDbTableComment)
self.isolated_local_models = [ModelWithDbTableComment]
with connection.schema_editor() as editor, self.assertNumQueries(0):
editor.alter_db_table_comment(
ModelWithDbTableComment, "Custom table comment", "New table comment"
)
@isolate_apps("schema")
@skipUnlessDBFeature("supports_comments", "supports_foreign_keys")
def test_db_comments_from_abstract_model(self):