mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-10-25 14:46:09 +00:00
Code Issues 32 Releases Wiki Activity

Fixed #18574 -- Make BaseFormSet.is_valid call its underlying forms' is_valid

Browse Source 
Thanks Simon Charette for the report and the initial patch.
This commit is contained in:
Andreas Hug
2012-12-06 20:00:56 +01:00
committed by Claude Paroz
parent 34dcf51e06
commit 66dfcc10b3
2 changed files with 23 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
django/forms/formsets.py
View File

@@ -267,7 +267,7 @@ class BaseFormSet(object):
def is_valid(self):
"""
Returns True if form.errors is empty for every form in self.forms.
Returns True if every form in self.forms is valid.
"""
if not self.is_bound:
return False
@@ -282,8 +282,7 @@ class BaseFormSet(object):
# This form is going to be deleted so any of its errors
# should not cause the entire formset to be invalid.
continue
if bool(self.errors[i]):
forms_valid = False
forms_valid &= form.is_valid()
return forms_valid and not bool(self.non_form_errors())
def full_clean(self):